-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI Tests and Artifact Cache Issues #92
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 6 6
Lines 181 181
=======================================
Hits 176 176
Misses 5 5 Continue to review full report at Codecov.
|
@@ -15,41 +15,42 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
version: | |||
- 1 | |||
- "1.0" # LTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this has already been discussed but I've done so many of these CI changes that I don't remember. Adding the 1.0 here will add more than 1 1.0 test. Is this ok, or do we want just the single 1.0 test, in which I will revert these matrix changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually just run 1 linux LTS job, but I don't think it matters too much. The tests should be pretty cheap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to have multiple
@@ -15,41 +15,42 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
version: | |||
- 1 | |||
- "1.0" # LTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to have multiple
Use CLI script to automatically replace the 1.3 test with a 1.5 test (if necessary), as well as use new cache steps to cache the julia build artifacts