Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Tests and Artifact Cache Issues #92

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Fix CI Tests and Artifact Cache Issues #92

merged 2 commits into from
Jan 22, 2021

Conversation

fchorney
Copy link
Member

Use CLI script to automatically replace the 1.3 test with a 1.5 test (if necessary), as well as use new cache steps to cache the julia build artifacts

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #92 (3c45171) into master (4d79bfe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files           6        6           
  Lines         181      181           
=======================================
  Hits          176      176           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d79bfe...3c45171. Read the comment docs.

@@ -15,41 +15,42 @@ jobs:
fail-fast: false
matrix:
version:
- 1
- "1.0" # LTS
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this has already been discussed but I've done so many of these CI changes that I don't remember. Adding the 1.0 here will add more than 1 1.0 test. Is this ok, or do we want just the single 1.0 test, in which I will revert these matrix changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually just run 1 linux LTS job, but I don't think it matters too much. The tests should be pretty cheap.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to have multiple

@@ -15,41 +15,42 @@ jobs:
fail-fast: false
matrix:
version:
- 1
- "1.0" # LTS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to have multiple

@fchorney fchorney merged commit 2fe36b1 into master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants