Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zenodo DOI badge #71

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Add zenodo DOI badge #71

merged 2 commits into from
Aug 20, 2020

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented Aug 19, 2020

Closes #70

@oxinabox
Copy link
Member

Should also add a Citation.bib file.

1 similar comment
@oxinabox
Copy link
Member

Should also add a Citation.bib file.

@oxinabox
Copy link
Member

Should also add a Citation.bib file

@rofinn
Copy link
Member Author

rofinn commented Aug 19, 2020

Should probably fix up the author list first.

@rofinn
Copy link
Member Author

rofinn commented Aug 19, 2020

Also, will we need to update the Citation.bib for every release?

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files           6        6           
  Lines         157      157           
=======================================
  Hits          149      149           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300855f...84d3640. Read the comment docs.

@oxinabox
Copy link
Member

Also, will we need to update the Citation.bib for every release?

No. Just once really, unless enough changes are made that the author list needs to change.
We should just not include the version of the package in the Citation.bib
And once we have a JOSS paper it can just be a citation for that paper

@rofinn rofinn merged commit 03c30e5 into master Aug 20, 2020
@rofinn rofinn deleted the rf/doi branch October 29, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citation?
2 participants