Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend [compat] CodecZlib = "0.6, 0.7" #58

Merged
merged 2 commits into from
Apr 4, 2020
Merged

Conversation

ablaom
Copy link
Contributor

@ablaom ablaom commented Mar 30, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files           6        6           
  Lines         156      156           
=======================================
  Hits          150      150           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb70c22...6311fa9. Read the comment docs.

@oxinabox
Copy link
Member

Thanks for this,
I just checked and there was no actual breaking change between 0.6 and 0.7 of CodecZlib. :-(

@oxinabox
Copy link
Member

Can you bump the version of JLSO in the Project.toml to 2.3.0 ?
Then can merge this and tag a release.

@ablaom
Copy link
Contributor Author

ablaom commented Apr 3, 2020

Not sure why continuous-integration is show orange. It looks done when you inspect.

@oxinabox Can we merge this please?

@oxinabox oxinabox merged commit 1975cb7 into invenia:master Apr 4, 2020
@oxinabox
Copy link
Member

oxinabox commented Apr 4, 2020

Travis has been weird about that. Thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants