Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule of thumb for when to use JLSO #121

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Rule of thumb for when to use JLSO #121

merged 2 commits into from
Feb 2, 2022

Conversation

cossio
Copy link

@cossio cossio commented Feb 2, 2022

Close #120 .

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #121 (2716487) into master (ada8158) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   97.67%   97.65%   -0.03%     
==========================================
  Files           6        6              
  Lines         215      213       -2     
==========================================
- Hits          210      208       -2     
  Misses          5        5              
Impacted Files Coverage Δ
src/metadata.jl 100.00% <0.00%> (ø)
src/serialization.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada8158...2716487. Read the comment docs.

@cossio
Copy link
Author

cossio commented Feb 2, 2022

merge?

@rofinn
Copy link
Member

rofinn commented Feb 2, 2022

Sorry, got distracted, but merging now. Thanks for the PR :)

@rofinn rofinn merged commit 7a24110 into invenia:master Feb 2, 2022
@cossio cossio deleted the note branch February 2, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule of thumb for when JLSO is inefficient in terms of file size
2 participants