Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify tests for Date/DateTime repr changes #64

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Modify tests for Date/DateTime repr changes #64

merged 2 commits into from
Jan 23, 2019

Conversation

fchorney
Copy link
Member

In Julia v"1.2.0-DEV.29" Date and DateTime repr changed from
"yyyy-mm-dd" to "Date(yyyy, m, d)", and similarly with DateTime. This
changed that comes out of show, so the tests that check the output
string of Intervals with Dates and DateTimes had to be changed to follow
suit.

Closes #59

@fchorney fchorney requested a review from omus as a code owner January 18, 2019 22:22
@codecov
Copy link

codecov bot commented Jan 18, 2019 •
edited
Loading

Codecov Report

Merging #64 into master will decrease coverage by 6.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   97.89%   91.21%   -6.68%     
==========================================
  Files           6        6              
  Lines         237      239       +2     
==========================================
- Hits          232      218      -14     
- Misses          5       21      +16
Impacted Files Coverage Δ
src/description.jl 66.66% <0%> (-33.34%) ⬇️
src/anchoredinterval.jl 91.22% <0%> (-7.02%) ⬇️
src/endpoint.jl 93.1% <0%> (-3.33%) ⬇️
src/interval.jl 97.02% <0%> (-1%) ⬇️
src/Intervals.jl 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549bd93...6db1ae7. Read the comment docs.

omus
omus reviewed Jan 19, 2019
View reviewed changes
test/anchoredinterval.jl Show resolved Hide resolved
test/anchoredinterval.jl Show resolved Hide resolved
omus
omus reviewed Jan 21, 2019
View reviewed changes
test/anchoredinterval.jl Outdated Show resolved Hide resolved
@omus
Copy link
Collaborator

omus commented Jan 22, 2019

Looks like all that is left is to drop Julia 0.6 from the CI files and from the REQUIRE. Please combine the existing commits before you add that commit.

@fchorney
Copy link
Member Author

Would I also change julia="0.6" to julia="0.7" in docs/make.jl?

@fchorney
Modify tests for Date/DateTime repr changes
cd87777 
- In Julia v"1.2.0-DEV.29" Date and DateTime repr changed from
"yyyy-mm-dd" to "Date(yyyy, m, d)", and similarly with DateTime. This
changed that comes out of show, so the tests that check the output
string of Intervals with Dates and DateTimes had to be changed to follow
suit.
@fchorney
Copy link
Member Author

Not too sure why some of the tests are failing with LoadError: LoadError: ArgumentError: Unknown time zone "Europe/London"

@omus
Copy link
Collaborator

omus commented Jan 23, 2019

I think you can change the "docs/make.jl" to use 1.0.

Not too sure why some of the tests are failing with LoadError: LoadError: ArgumentError: Unknown time zone "Europe/London"

In the build step the tzdata failed to download.

@omus
Copy link
Collaborator

omus commented Jan 23, 2019

JuliaTime/TimeZones.jl#180

@omus omus merged commit 66f9de7 into master Jan 23, 2019
@omus omus deleted the fc/date-printing-fix branch January 23, 2019 21:11
@omus omus mentioned this pull request Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omus omus omus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchorney @omus