-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't release canary on skip-release by default, add force flag #993
Conversation
14d433d
to
fea4546
Compare
fea4546
to
20cd3d8
Compare
I have added it as a configurable option. This is solved.
I just turned it off. 🤷♂
To me it looks like your changes to
I feel like a new user would expect the release to be skipped also. I like this, it's a good sane default. This could be viewed as a Sometimes I use a |
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
+ Coverage 80.91% 80.94% +0.02%
==========================================
Files 44 44
Lines 3328 3332 +4
Branches 705 668 -37
==========================================
+ Hits 2693 2697 +4
Misses 465 465
Partials 170 170
Continue to review full report at Codecov.
|
🚀 PR was released in |
Thanks for wrapping this up! Sorry I didn't get back to it. |
Fixes #962
What Changed
Canaries now no longer publish for PRs that skip the release. A flag
--force
was added to thecanary
subcommand to make it always publish, regardless of label.Why
Often times for things like docs updates or other trivial changes deploying a canary is extra noise that's unnecessary.
Open questions
shipit
need to be updated with some sort of force flag?canary
function. Should I increase it or refactor that function to pull out some checks?--respect-labels
or something)Todo:
📦 Published PR as canary version:
under canary scope @auto-canary@9.15.4-canary.993.13171.0
✨ Test out this PR locally via:
npm install @auto-canary/auto@9.15.4-canary.993.13171.0 npm install @auto-canary/core@9.15.4-canary.993.13171.0 npm install @auto-canary/all-contributors@9.15.4-canary.993.13171.0 npm install @auto-canary/chrome@9.15.4-canary.993.13171.0 npm install @auto-canary/conventional-commits@9.15.4-canary.993.13171.0 npm install @auto-canary/crates@9.15.4-canary.993.13171.0 npm install @auto-canary/first-time-contributor@9.15.4-canary.993.13171.0 npm install @auto-canary/git-tag@9.15.4-canary.993.13171.0 npm install @auto-canary/gradle@9.15.4-canary.993.13171.0 npm install @auto-canary/jira@9.15.4-canary.993.13171.0 npm install @auto-canary/maven@9.15.4-canary.993.13171.0 npm install @auto-canary/npm@9.15.4-canary.993.13171.0 npm install @auto-canary/omit-commits@9.15.4-canary.993.13171.0 npm install @auto-canary/omit-release-notes@9.15.4-canary.993.13171.0 npm install @auto-canary/released@9.15.4-canary.993.13171.0 npm install @auto-canary/s3@9.15.4-canary.993.13171.0 npm install @auto-canary/slack@9.15.4-canary.993.13171.0 npm install @auto-canary/twitter@9.15.4-canary.993.13171.0 npm install @auto-canary/upload-assets@9.15.4-canary.993.13171.0 # or yarn add @auto-canary/auto@9.15.4-canary.993.13171.0 yarn add @auto-canary/core@9.15.4-canary.993.13171.0 yarn add @auto-canary/all-contributors@9.15.4-canary.993.13171.0 yarn add @auto-canary/chrome@9.15.4-canary.993.13171.0 yarn add @auto-canary/conventional-commits@9.15.4-canary.993.13171.0 yarn add @auto-canary/crates@9.15.4-canary.993.13171.0 yarn add @auto-canary/first-time-contributor@9.15.4-canary.993.13171.0 yarn add @auto-canary/git-tag@9.15.4-canary.993.13171.0 yarn add @auto-canary/gradle@9.15.4-canary.993.13171.0 yarn add @auto-canary/jira@9.15.4-canary.993.13171.0 yarn add @auto-canary/maven@9.15.4-canary.993.13171.0 yarn add @auto-canary/npm@9.15.4-canary.993.13171.0 yarn add @auto-canary/omit-commits@9.15.4-canary.993.13171.0 yarn add @auto-canary/omit-release-notes@9.15.4-canary.993.13171.0 yarn add @auto-canary/released@9.15.4-canary.993.13171.0 yarn add @auto-canary/s3@9.15.4-canary.993.13171.0 yarn add @auto-canary/slack@9.15.4-canary.993.13171.0 yarn add @auto-canary/twitter@9.15.4-canary.993.13171.0 yarn add @auto-canary/upload-assets@9.15.4-canary.993.13171.0