-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins/npm): permit lerna publish to use automation tokens #2032
feat(plugins/npm): permit lerna publish to use automation tokens #2032
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2032 +/- ##
=======================================
Coverage 80.23% 80.23%
=======================================
Files 66 66
Lines 5394 5394
Branches 1249 1249
=======================================
Hits 4328 4328
Misses 706 706
Partials 360 360
Continue to review full report at Codecov.
|
My apologies, while trying to figure out how to publish a single https://github.com/intuit/auto/tree/main/plugins/npm#using-automation-tokens-from-npm I still think that supporting this behavior by default may be relevant given that most people are running auto in |
Yeah, I added the documentation after stumbling across this. It's not the best experience. I'd be 👍 for the change. |
@hydrosquall I like the change. Could you remove that bit from the docs since it isn't needed anymore? |
Updated in 3cfe77a |
🚀 PR was released in |
What Changed
lerna publish
was failing authentication even with a token that clearly had write access, as usingyarn npm publish
works. As a result, the canary build feature ofauto
wasn't working.Examining Lerna doesn't work with NPM automation tokens lerna/lerna#2788 revealed the root issue, automation tokens fail the identity check used at the start of
lerna publish
unless a flag is passed.Updates locations in the
auto
code wherelerna publish
is called to not require the identify verification check.Why
auto
in a monorepo was failing, using a non-automation token is not an option for this projectTodo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major
Testing
I'm not sure how to trigger a canary package publish within this repo (maybe a tag is necessary), so I've published a fork of this under my own scope to test separately.