Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to pass additional flags to pod repo push #1464

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

hborawski
Copy link
Collaborator

What Changed

Adds a new option to add any additional flags to the pod repo push command

Why

Some private pod usage requires passes a --sources flag for the command to pass the podspec lint
Todo:

  • Add tests
  • Add docs

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #1464 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1464   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files          58       58           
  Lines        4300     4301    +1     
  Branches      901      952   +51     
=======================================
+ Hits         3487     3488    +1     
  Misses        570      570           
  Partials      243      243           
Impacted Files Coverage Δ
plugins/cocoapods/src/index.ts 89.55% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 195b791...9cec0ac. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit c7c2678 into intuit:master Aug 13, 2020
@hborawski hborawski deleted the pod-push-flags branch August 13, 2020 16:31
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.50.3 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants