Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use tag version for release title, prevent using annotation #1083

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 27, 2020

What Changed

Enforce the title of a GitHub release when creating it.

Why

The repos.createRelease function will make the title of the release the annotation for the tag. This annotation may contain more than just the number as seen here. We always just want the title to be the tag version.

📦 Published PR as canary version: under canary scope @auto-canary@9.21.2-canary.1083.14191.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.21.2-canary.1083.14191.0
npm install @auto-canary/auto@9.21.2-canary.1083.14191.0
npm install @auto-canary/core@9.21.2-canary.1083.14191.0
npm install @auto-canary/all-contributors@9.21.2-canary.1083.14191.0
npm install @auto-canary/chrome@9.21.2-canary.1083.14191.0
npm install @auto-canary/cocoapods@9.21.2-canary.1083.14191.0
npm install @auto-canary/conventional-commits@9.21.2-canary.1083.14191.0
npm install @auto-canary/crates@9.21.2-canary.1083.14191.0
npm install @auto-canary/exec@9.21.2-canary.1083.14191.0
npm install @auto-canary/first-time-contributor@9.21.2-canary.1083.14191.0
npm install @auto-canary/gh-pages@9.21.2-canary.1083.14191.0
npm install @auto-canary/git-tag@9.21.2-canary.1083.14191.0
npm install @auto-canary/gradle@9.21.2-canary.1083.14191.0
npm install @auto-canary/jira@9.21.2-canary.1083.14191.0
npm install @auto-canary/maven@9.21.2-canary.1083.14191.0
npm install @auto-canary/npm@9.21.2-canary.1083.14191.0
npm install @auto-canary/omit-commits@9.21.2-canary.1083.14191.0
npm install @auto-canary/omit-release-notes@9.21.2-canary.1083.14191.0
npm install @auto-canary/released@9.21.2-canary.1083.14191.0
npm install @auto-canary/s3@9.21.2-canary.1083.14191.0
npm install @auto-canary/slack@9.21.2-canary.1083.14191.0
npm install @auto-canary/twitter@9.21.2-canary.1083.14191.0
npm install @auto-canary/upload-assets@9.21.2-canary.1083.14191.0
# or 
yarn add @auto-canary/bot-list@9.21.2-canary.1083.14191.0
yarn add @auto-canary/auto@9.21.2-canary.1083.14191.0
yarn add @auto-canary/core@9.21.2-canary.1083.14191.0
yarn add @auto-canary/all-contributors@9.21.2-canary.1083.14191.0
yarn add @auto-canary/chrome@9.21.2-canary.1083.14191.0
yarn add @auto-canary/cocoapods@9.21.2-canary.1083.14191.0
yarn add @auto-canary/conventional-commits@9.21.2-canary.1083.14191.0
yarn add @auto-canary/crates@9.21.2-canary.1083.14191.0
yarn add @auto-canary/exec@9.21.2-canary.1083.14191.0
yarn add @auto-canary/first-time-contributor@9.21.2-canary.1083.14191.0
yarn add @auto-canary/gh-pages@9.21.2-canary.1083.14191.0
yarn add @auto-canary/git-tag@9.21.2-canary.1083.14191.0
yarn add @auto-canary/gradle@9.21.2-canary.1083.14191.0
yarn add @auto-canary/jira@9.21.2-canary.1083.14191.0
yarn add @auto-canary/maven@9.21.2-canary.1083.14191.0
yarn add @auto-canary/npm@9.21.2-canary.1083.14191.0
yarn add @auto-canary/omit-commits@9.21.2-canary.1083.14191.0
yarn add @auto-canary/omit-release-notes@9.21.2-canary.1083.14191.0
yarn add @auto-canary/released@9.21.2-canary.1083.14191.0
yarn add @auto-canary/s3@9.21.2-canary.1083.14191.0
yarn add @auto-canary/slack@9.21.2-canary.1083.14191.0
yarn add @auto-canary/twitter@9.21.2-canary.1083.14191.0
yarn add @auto-canary/upload-assets@9.21.2-canary.1083.14191.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Mar 27, 2020
@hipstersmoothie hipstersmoothie merged commit 5eb1c9f into master Mar 27, 2020
@hipstersmoothie hipstersmoothie deleted the next-title-bug branch March 27, 2020 18:56
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.21.2 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants