Merge pull request #1632 from intuit/verify-timeout

add timeout when verifying auth to remote

package.json

@@ -120,7 +120,12 @@
       "html",
       "lcov",
       "text"
-    ]
+    ],
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    }
   },
   "ignite": {
     "repo": "intuit/auto",

packages/cli/__tests__/main.test.ts

@@ -3,6 +3,7 @@ import { runCli, execute } from "../src/run";
 process.env.GH_TOKEN = "XXXX";
 
 jest.mock("@octokit/rest");
+jest.mock("../../core/src/utils/verify-auth");
 
 test("throws error for unknown args", async () => {
   process.exit = jest.fn() as any;

packages/core/src/utils/__tests__/verify-auth.test.ts

@@ -8,6 +8,7 @@ describe("verify-auth", () => {
   test("should handle error", async () => {
     spawn.mockImplementationOnce(() => ({
       stderr: { on: () => {} },
+      kill: () => {},
       on: () => {
         throw new Error();
       },
@@ -18,6 +19,7 @@ describe("verify-auth", () => {
   test("should verify auth when we can push to remote", async () => {
     spawn.mockImplementationOnce(() => ({
       stderr: { on: () => {} },
+      kill: () => {},
       on: (_: string, cb: () => void) => cb(),
     }));
     expect(await verifyAuth("origin", "master")).toBe(true);
@@ -29,6 +31,7 @@ describe("verify-auth", () => {
         on: (_: string, cb: (data: string) => void) =>
           cb("fatal: could not read Username"),
       },
+      kill: () => {},
       on: (_: string, cb: () => void) => cb(),
     }));
     expect(await verifyAuth("bad", "master")).toBe(false);

packages/core/src/utils/verify-auth.ts

@@ -5,6 +5,15 @@ import { spawn } from "child_process";
  */
 export default function verifyAuth(remote: string, branch: string) {
   return new Promise<boolean>((resolve) => {
+    let timeout: NodeJS.Timeout | null = null;
+
+    /** Clear the timeout timeout */
+    const clear = () => {
+      if (timeout) {
+        clearTimeout(timeout);
+      }
+    };
+
     try {
       const child = spawn(
         `git push --dry-run --no-verify ${remote} HEAD:${branch} -q`,
@@ -16,20 +25,27 @@ export default function verifyAuth(remote: string, branch: string) {
         }
       );
 
+      timeout = setTimeout(() => {
+        child.kill(0);
+        resolve(false);
+      }, 5 * 1000);
+
       let err = "";
 
       child.stderr.on("data", (data) => {
         err += data.toString();
       });
 
       child.on("exit", () => {
+        clear();
         resolve(
           !err.startsWith("fatal: could not read Username") &&
             !err.startsWith("ssh_askpass") &&
             !err.includes("fatal")
         );
       });
     } catch (error) {
+      clear();
       resolve(false);
     }
   });