Skip to content

Commit

Permalink
Merge pull request #1762 from intuit/npm-bug
Browse files Browse the repository at this point in the history
fix commit message when using npx in non-monorepo
  • Loading branch information
hipstersmoothie authored Jan 28, 2021
2 parents 8456b2a + 57ea93f commit 1bcc639
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
14 changes: 7 additions & 7 deletions plugins/npm/__tests__/npm.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ describe("publish", () => {
Auto.SEMVER.patch,
"--no-commit-hooks",
"-m",
"Bump version to: %s [skip ci]",
"'\"Bump version to: %s [skip ci]\"'",
"--loglevel",
"silly",
]);
Expand Down Expand Up @@ -519,7 +519,7 @@ describe("publish", () => {
Auto.SEMVER.patch,
"--no-commit-hooks",
"-m",
"Bump version to: %s [skip ci]",
"'\"Bump version to: %s [skip ci]\"'",
]);
});

Expand Down Expand Up @@ -554,7 +554,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
'\'"Bump version to: %s [skip ci]"\'',
"'\"Bump version to: %s [skip ci]\"'",
false,
]);
});
Expand Down Expand Up @@ -590,7 +590,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
'\'"Bump version to: %s [skip ci]"\'',
"'\"Bump version to: %s [skip ci]\"'",
false,
]);
});
Expand Down Expand Up @@ -626,7 +626,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
'\'"Bump version to: %s [skip ci]"\'',
"'\"Bump version to: %s [skip ci]\"'",
"--exact",
]);

Expand Down Expand Up @@ -750,7 +750,7 @@ describe("publish", () => {
"1.0.1",
"--no-commit-hooks",
"-m",
"Bump version to: %s [skip ci]",
"'\"Bump version to: %s [skip ci]\"'",
]);
});

Expand Down Expand Up @@ -786,7 +786,7 @@ describe("publish", () => {
"--yes",
"--no-push",
"-m",
'\'"Bump version to: %s [skip ci]"\'',
"'\"Bump version to: %s [skip ci]\"'",
false,
]);
});
Expand Down
4 changes: 2 additions & 2 deletions plugins/npm/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import setTokenOnCI, { getRegistry, DEFAULT_REGISTRY } from "./set-npm-token";
import { writeFile, isMonorepo, readFile, getLernaJson } from "./utils";

const { isCi } = envCi();
const VERSION_COMMIT_MESSAGE = "Bump version to: %s [skip ci]";
const VERSION_COMMIT_MESSAGE = `'"Bump version to: %s [skip ci]"'`;

/** Get the last published version for a npm package */
async function getPublishedVersion(name: string) {
Expand Down Expand Up @@ -947,7 +947,7 @@ export default class NPMPlugin implements IPlugin {
"-m",
isIndependent
? '"Bump independent versions [skip ci]"'
: `'"${VERSION_COMMIT_MESSAGE}"'`,
: VERSION_COMMIT_MESSAGE,
this.exact && "--exact",
...verboseArgs,
]);
Expand Down

0 comments on commit 1bcc639

Please sign in to comment.