Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Rx dependencies to support Xcode 12.5 #274

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

badrinathvm
Copy link
Contributor

Before you make a Pull Request, read the important guidelines:

Support for Xcode 12.5

Issue Link 🔗

  • Is this a bug fix or a feature?
  • Does it break any existing functionality?

Goals of this PR 🎉

  • Why is the change important?
  • What does this fix?
  • How far has it been tested?

How Has This Been Tested 🔍

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • User Interface Testing
  • Application Testing

Test Configuration 👾

  • Xcode version:
  • Device/Simulator
  • iOS version || MacOSX version

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@badrinathvm badrinathvm requested a review from croossin June 9, 2021 01:36
@croossin croossin merged commit dbf0eb7 into master Jun 9, 2021
@croossin croossin deleted the task/support_for_xcode_12_5 branch June 9, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants