Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for not showing confetti for the first time #270

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

badrinathvm
Copy link
Contributor

@badrinathvm badrinathvm commented Mar 3, 2021

Before you make a Pull Request, read the important guidelines:

Fix for not showing the Confetti for the first time.

Issue Link 🔗

  • Is this a bug fix or a feature? : Bug
  • Does it break any existing functionality?: None

Goals of this PR 🎉

  • Why is the change important?
  • What does this fix?
  • How far has it been tested?

How Has This Been Tested 🔍

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • User Interface Testing
  • Application Testing

Test Configuration 👾

  • Xcode version: Xcode 12.4
  • Device/Simulator: iPhone 11
  • iOS version || MacOSX version : 14.4

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@badrinathvm badrinathvm requested a review from croossin March 3, 2021 21:24
@badrinathvm badrinathvm merged commit 27126a7 into master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants