The label gets out of bounds in example #19
Assignees
Labels
bug
Something isn't working
Comments
gerchicov-bp
changed the title
|
I can confirm the issue on iPhone SE. |
|
@croossin Is this an issue in the CardParts code, or just the example? Can I take a poke around at it? |
|
@lwdupont That would be awesome if you could! |
|
@croossin So I looked at it. Thinking CardParts should handle this, I traced into where it's setting up the CardPartsTitleView. I tweaked updateContraints() slightly to pin the horizontal to both edges. I'll open up a pull request soonish, maybe tomorrow. Results:
|
lwdupont
pushed a commit
that referenced
this issue
May 31, 2018
…rtTitleView. The CardPartTitleView was setting the horizontal constraint to pin left, but nothing on the right, so the UILabel just floated off of the containing CardPartVIew. Figured this fix was good because then the developer can decide if they want to go further in fixing up their label (vs CardParts deciding for them).
croossin
added a commit
that referenced
this issue
May 31, 2018
…t-part Tweak for issue #19 to fix the going off the right edge of the CardPartTitleView
|
This was fixed in PR #23 and released in CardParts 2.3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
iPhone 5s simulator:
The text was updated successfully, but these errors were encountered: