Create monaco and vscode editor bridge #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhushanlaware
previously approved these changes
Jul 27, 2022
bhushanlaware
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monaco editor is built from vscode source, If we use firepad-x in vscode, we cannot add monaco-editor as a dependency as it will increase the bundle size and we are just adding duplicate code which already exists in vscode
So we have created a adapter which provides native monaco editor utils when used without vscode and when used with vscode the vscode consumer provide vscode specific editor utils
For a normal consumer of firepad this should make no difference as NativeMonacoEditorUtils is used by default