[uss_qualifier] NetRID: migrate some severities to documentation #936
Conversation
| @@ -362,21 +362,18 @@ def _evaluate_timestamp( | |||
| check.record_failed( | |||
| f"Timestamp not present", | |||
| details=f"The timestamp must be specified.", | |||
| severity=Severity.High, | |||
There was a problem hiding this comment.
Severity.High here is effectively relying on the high-severity failing check to abort the scenario when timestamp_obs is None, so we won't reach the later parts of the scenario if the check fails in this way. Since that abort will no longer happen given that we have marked all failures of that check to be Medium severity, we'll need to manually wrap the UTC and parse checks below in an if statement. Or, we could split these 3 different failure modes into 3 different checks and keep the first one as High severity. Or we could make this check High severity, but I think that is the least desirable because I don't think a missing timestamp should be a scenario-ending failure in the common dictionary evaluator.
There was a problem hiding this comment.
I think that what makes the most sense is to split this into at least two checks of different severities. will update.
There was a problem hiding this comment.
There's actually no reason to mark the check with a high severity if we guard the other checks behind an if, so going with the option of having a separate check with medium severity.
| @@ -442,7 +438,6 @@ def _evaluate_speed( | |||
| check.record_failed( | |||
| f"Speed not present", | |||
| details=f"The speed must be specified.", | |||
| severity=Severity.High, | |||
There was a problem hiding this comment.
Note to self: similarly to the timestamp, this might deserve a separate check and we might not need to abort the scenario because of the missing field.
| @@ -482,7 +475,6 @@ def _evaluate_track( | |||
| check.record_failed( | |||
| f"Track direction not present", | |||
| details=f"The track direction must be specified.", | |||
| severity=Severity.High, | |||
Shastick
force-pushed
the
migrate-some-rid-severities
branch
from
b73344e to
61a9992
Compare
Some more steps towards #404