-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev] Lower docker image healthcheck interval #915
Conversation
Before:
After:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix.
Nit: title can be updated to inclue a [dev]
or [local_dev]
tag?
Yup fixed, didn't found any recent examples in last PRs :P |
Please make sure the healthcheck do not add too much lines to logs, if so we may want to disable specifically those. |
Running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
The health checks have a interval of 30s by default, who can be quite long when restarting mocks for testing multiple time.
This PR lower the interval to 3s, making restarts / starts faster.
Since the heath checks are only simple curl call or a simple
exit 0
, this shouldn't probably hurt CPU usage.