Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Lower docker image healthcheck interval #915

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

the-glu
Copy link
Contributor

@the-glu the-glu commented Jan 30, 2025

The health checks have a interval of 30s by default, who can be quite long when restarting mocks for testing multiple time.

This PR lower the interval to 3s, making restarts / starts faster.

Since the heath checks are only simple curl call or a simple exit 0, this shouldn't probably hurt CPU usage.

@the-glu the-glu marked this pull request as ready for review January 30, 2025 08:59
@the-glu
Copy link
Contributor Author

the-glu commented Jan 30, 2025

Before:

[+] Running 10/10
 ✔ Container mock_uss_ridsp_v19              Healthy                                                                   30.8s 
 ✔ Container mock_uss_geoawareness           Healthy                                                                   30.8s 
 ✔ Container mock_uss_scdsc_a                Healthy                                                                   30.8s 
 ✔ Container mock_uss_tls_proxy              Healthy                                                                    1.3s 
 ✔ Container mock_uss_ridsp                  Healthy                                                                   31.3s 
 ✔ Container mock_uss_scdsc_b                Healthy                                                                   31.3s 
 ✔ Container mock_uss_riddp_v19              Healthy                                                                   30.8s 
 ✔ Container mock_uss_riddp                  Healthy                                                                   30.8s 
 ✔ Container mock_uss_tracer                 Healthy                                                                   30.8s 
 ✔ Container mock_uss_scdsc_interaction_log  Healthy                                                                   31.3s 

After:

[+] Running 10/10
✔ Container mock_uss_tls_proxy              Healthy                                                                    1.2s 
✔ Container mock_uss_riddp_v19              Healthy                                                                    3.7s 
✔ Container mock_uss_geoawareness           Healthy                                                                    3.7s 
✔ Container mock_uss_ridsp_v19              Healthy                                                                    4.2s 
✔ Container mock_uss_ridsp                  Healthy                                                                    3.7s 
✔ Container mock_uss_scdsc_b                Healthy                                                                    4.2s 
✔ Container mock_uss_scdsc_interaction_log  Healthy                                                                    3.7s 
✔ Container mock_uss_tracer                 Healthy                                                                    4.2s 
✔ Container mock_uss_scdsc_a                Healthy                                                                    4.2s 
✔ Container mock_uss_riddp                  Healthy                                                                    3.7s

Copy link
Contributor

@Shastick Shastick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

Nit: title can be updated to inclue a [dev] or [local_dev] tag?

@the-glu the-glu changed the title Lower docker image healthcheck interval [dev] Lower docker image healthcheck interval Jan 30, 2025
@the-glu
Copy link
Contributor Author

the-glu commented Jan 30, 2025

Nit: title can be updated to inclue a [dev] or [local_dev] tag?

Yup fixed, didn't found any recent examples in last PRs :P

@barroco
Copy link
Contributor

barroco commented Jan 30, 2025

Please make sure the healthcheck do not add too much lines to logs, if so we may want to disable specifically those.

@the-glu
Copy link
Contributor Author

the-glu commented Jan 30, 2025

Please make sure the healthcheck do not add too much lines to logs, if so we may want to disable specifically those.

Running docker compose -f docker-compose.yaml -p mocks logs -f shows no logs, so I assume the healthcheck call is not recorded and it should be fine.

Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mickmis mickmis merged commit 63c63b7 into interuss:main Jan 30, 2025
20 checks passed
@mickmis mickmis deleted the lower_hc_interval branch January 30, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants