feat: punchout identity provider #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisie96
changed the title
shauke
changed the title
Eisie96
force-pushed
the
refactor/punchout-identity-provider
branch
3 times, most recently
from
d5654e0 to
46fd3df
Compare
MaxKless
suggested changes
Nov 8, 2021
src/app/extensions/punchout/identity-provider/punchout-identity-provider.spec.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/punchout/identity-provider/punchout-identity-provider.spec.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/punchout/identity-provider/punchout-identity-provider.spec.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/punchout/identity-provider/punchout-identity-provider.spec.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/punchout/identity-provider/punchout-identity-provider.ts
Show resolved
Hide resolved
Eisie96
force-pushed
the
refactor/punchout-identity-provider
branch
from
b8b0c0f to
a02614b
Compare
|
EDIT: TWO WINDOWS IN THE SAME BROWSER ARE NOT A RELEVANT USE-CASE SO THIS BUG IS IRRELEVANT. KEEPING IT UP FOR TRANSPARENCY Sadly, I found a bug when opening two windows with OCI punchout when using a static punchout identity provider.
When building the PWA with |
MaxKless
approved these changes
Nov 22, 2021
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: Marcus Schmidt <marcus.schmidt@intershop.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
OCI Punchout Sessions gets lost after Reload.
Issue Number: Closes #
What Is the New Behavior?
OCI Punchout Sessions is available after Reload. Therefore is the punchout guard refactored to a new identity provider, which saves the actual basketId to the session storage. Furthermore it is possible to override the actual identity provider on specific routes.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information
AB#70891