Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: product attachments #840

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Conversation

suschneider
Copy link
Collaborator

@suschneider suschneider commented Aug 18, 2021

PR Type

[x] Feature

What Is the Current Behavior?

The PWA does currently not support the display of product attachments.
Issue Number: Closes #767

What Is the New Behavior?

Product attachment information are displayed on product detail page similar to the Responsive Starter Store regarding the IAD changes mentioned in issue #767.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#66193

@suschneider suschneider added the feature New feature or request label Aug 18, 2021
@suschneider suschneider added this to the 1.1 milestone Aug 18, 2021
@suschneider suschneider requested a review from SGrueber August 18, 2021 13:14
@suschneider suschneider self-assigned this Aug 18, 2021
@suschneider suschneider force-pushed the feature/product-attachments branch 4 times, most recently from b25b3db to 95efc72 Compare August 20, 2021 14:59
@suschneider suschneider requested a review from SGrueber August 20, 2021 16:13
@suschneider suschneider force-pushed the feature/product-attachments branch from 95efc72 to 66e3c25 Compare August 23, 2021 08:14
@suschneider suschneider force-pushed the feature/product-attachments branch from 66e3c25 to 3ddcf77 Compare August 30, 2021 11:09
@suschneider suschneider requested review from M-Behr and shauke August 30, 2021 12:31
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

@suschneider suschneider force-pushed the feature/product-attachments branch from 3ddcf77 to ae59c9c Compare August 30, 2021 15:02
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suschneider suschneider merged commit d275b95 into develop Aug 31, 2021
@suschneider suschneider deleted the feature/product-attachments branch August 31, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display product attachments at the product details page
4 participants