-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: product attachments #840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
requested changes
Aug 20, 2021
...app/pages/product/product-detail-info-accordion/product-detail-info-accordion.component.html
Outdated
Show resolved
Hide resolved
suschneider
force-pushed
the
feature/product-attachments
branch
4 times, most recently
from
August 20, 2021 14:59
b25b3db
to
95efc72
Compare
suschneider
force-pushed
the
feature/product-attachments
branch
from
August 23, 2021 08:14
95efc72
to
66e3c25
Compare
SGrueber
approved these changes
Aug 23, 2021
suschneider
force-pushed
the
feature/product-attachments
branch
from
August 30, 2021 11:09
66e3c25
to
3ddcf77
Compare
M-Behr
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👍
suschneider
force-pushed
the
feature/product-attachments
branch
from
August 30, 2021 15:02
3ddcf77
to
ae59c9c
Compare
shauke
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
The PWA does currently not support the display of product attachments.
Issue Number: Closes #767
What Is the New Behavior?
Product attachment information are displayed on product detail page similar to the Responsive Starter Store regarding the IAD changes mentioned in issue #767.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#66193