Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translations with links and callback (ISREST-915) #8

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Nov 19, 2019

No description provided.

@shauke shauke added the enhancement Enhancement to an existing feature label Nov 19, 2019
@shauke shauke added this to the 0.17 milestone Nov 19, 2019
@shauke shauke requested a review from fmalcher November 19, 2019 10:18
Copy link
Collaborator

@fmalcher fmalcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM

src/app/core/directives/server-html.directive.ts Outdated Show resolved Hide resolved
src/app/core/directives/server-html.directive.ts Outdated Show resolved Hide resolved
src/app/core/directives/server-html.directive.ts Outdated Show resolved Hide resolved
@Sebastian-Haehnlein Sebastian-Haehnlein force-pushed the feature/translations-with-links-and-callback branch from fb6166b to c22de5f Compare November 27, 2019 11:00
dhhyi
dhhyi previously approved these changes Dec 11, 2019
@dhhyi
Copy link
Collaborator

dhhyi commented Dec 11, 2019

@shauke Please merge when ready 😉

@shauke shauke force-pushed the feature/translations-with-links-and-callback branch from c22de5f to 988a6aa Compare December 11, 2019 19:07
@shauke shauke force-pushed the feature/translations-with-links-and-callback branch from 988a6aa to d094a8e Compare December 11, 2019 19:41
@shauke shauke force-pushed the feature/translations-with-links-and-callback branch from d094a8e to 5dab2b4 Compare December 12, 2019 15:29
@shauke shauke merged commit 08416f7 into develop Dec 13, 2019
@shauke shauke deleted the feature/translations-with-links-and-callback branch December 13, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants