Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add missing quickorder link in mobile view #794

Merged
merged 3 commits into from
Jul 29, 2021

Conversation

cbratsch
Copy link
Contributor

@cbratsch cbratsch commented Jul 23, 2021

PR Type

[x] Bugfix

What Is the Current Behavior?

The quick order link is missing in phone (xs) view. This means no access to the feature for phone devices.

What Is the New Behavior?

The quick order link is visible in phone view. It is placed in the hamburger menu (see IAD).
image

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#65435

@cbratsch cbratsch requested review from M-Behr and shauke July 23, 2021 05:04
@shauke shauke added this to the 1.0 milestone Jul 23, 2021
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There styling in mobile view does not match the other links
    image

  • The current rendering logic does not work for the Sticky Header
    image

  • It would be nice to still handle the feature toggle check only in the lazy component and also handle the div rendering in the header-quickorder.component.html itself so one can still use only <ish-lazy-header-quickorder></ish-lazy-header-quickorder> where ever needed. The additional input is fine. Internally ng-template (see product-image.component.html could be used).

Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Space between icon and quick order link in mobile hamburger menu.
  • Remove quick order link from sticky header. I discussed this with @rkarl-ish. We can later add the quick order icon next to the search icon if required. Then we have to check that the categories and the icon do not overlap in different languages and devices.

@cbratsch cbratsch requested review from shauke and M-Behr July 27, 2021 04:36
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the hover effect of the quick order link is inconsistent with the other links in hamburger menu. Intuitively, I would say yours is right and all the others are incorrect.

I discussed this with @iwiederhold and your styling is correct. Maybe the other link hover styles were removed with this CSS purge thing? Can you match the other link hover styles to yours or do we make an extra ticket for that?

@cbratsch cbratsch requested a review from M-Behr July 27, 2021 09:25
@cbratsch cbratsch requested a review from shauke July 28, 2021 04:33
@M-Behr
Copy link

M-Behr commented Jul 28, 2021

I noticed that the hover effect of the quick order link is inconsistent with the other links in hamburger menu. Intuitively, I would say yours is right and all the others are incorrect.

I discussed this with @iwiederhold and your styling is correct. Maybe the other link hover styles were removed with this CSS purge thing? Can you match the other link hover styles to yours or do we make an extra ticket for that?

I tracked a minor bug for this VD issue: #805

Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an additional blank character in "Quick Order". This results in the link not being in line with the other links:
QuickOrderLink

@shauke
Copy link
Collaborator

shauke commented Jul 28, 2021

I found an additional blank character in "Quick Order". This results in the link not being in line with the other links:

This is fixed with the latest changes.

@M-Behr
Copy link

M-Behr commented Jul 28, 2021

I found an additional blank character in "Quick Order". This results in the link not being in line with the other links:

This is fixed with the latest changes.

Hmm, but I can still see it. When I remove the blank character with the browser tool, it looks fine. I also tested it with an incognito window. Does it no longer occur in your local environment? Maybe it has something to do with the review server.

@shauke shauke linked an issue Jul 28, 2021 that may be closed by this pull request
shauke
shauke previously approved these changes Jul 28, 2021
@shauke shauke requested a review from M-Behr July 28, 2021 13:44
M-Behr
M-Behr previously approved these changes Jul 29, 2021
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@shauke shauke dismissed stale reviews from M-Behr and themself via 22d731d July 29, 2021 12:12
@shauke shauke force-pushed the fix/add_missing_quickorder_link_in_mobile_view branch from 64a91a1 to 22d731d Compare July 29, 2021 12:12
@shauke shauke merged commit dafafe1 into develop Jul 29, 2021
@shauke shauke deleted the fix/add_missing_quickorder_link_in_mobile_view branch July 29, 2021 19:45
shauke pushed a commit that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect hover styles for nav links in hamburger menu
3 participants