-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/add missing quickorder link in mobile view #794
Fix/add missing quickorder link in mobile view #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The current rendering logic does not work for the Sticky Header
-
It would be nice to still handle the feature toggle check only in the lazy component and also handle the
div
rendering in theheader-quickorder.component.html
itself so one can still use only<ish-lazy-header-quickorder></ish-lazy-header-quickorder>
where ever needed. The additional input is fine. Internallyng-template
(seeproduct-image.component.html
could be used).
src/app/shell/header/header-default/header-default.component.html
Outdated
Show resolved
Hide resolved
src/app/extensions/quickorder/shared/header-quickorder/header-quickorder.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Space between icon and quick order link in mobile hamburger menu.
- Remove quick order link from sticky header. I discussed this with @rkarl-ish. We can later add the quick order icon next to the search icon if required. Then we have to check that the categories and the icon do not overlap in different languages and devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the hover effect of the quick order link is inconsistent with the other links in hamburger menu. Intuitively, I would say yours is right and all the others are incorrect.
I discussed this with @iwiederhold and your styling is correct. Maybe the other link hover styles were removed with this CSS purge thing? Can you match the other link hover styles to yours or do we make an extra ticket for that?
src/app/shell/header/header-default/header-default.component.html
Outdated
Show resolved
Hide resolved
src/app/shell/header/user-information-mobile/user-information-mobile.component.html
Outdated
Show resolved
Hide resolved
I tracked a minor bug for this VD issue: #805 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed with the latest changes. |
Hmm, but I can still see it. When I remove the blank character with the browser tool, it looks fine. I also tested it with an incognito window. Does it no longer occur in your local environment? Maybe it has something to do with the review server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👍
64a91a1
to
22d731d
Compare
PR Type
[x] Bugfix
What Is the Current Behavior?
The quick order link is missing in phone (xs) view. This means no access to the feature for phone devices.
What Is the New Behavior?
The quick order link is visible in phone view. It is placed in the hamburger menu (see IAD).
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#65435