Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap budget-widget to approval scope #493

Merged
merged 1 commit into from
Jan 6, 2021
Merged

fix: wrap budget-widget to approval scope #493

merged 1 commit into from
Jan 6, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jan 5, 2021

PR Type

[x] Bugfix

What Is the Current Behavior?

Logging into B2C storefront displays an error on the my-account page

  1. goto https://intershoppwa.azurewebsites.net/home
  2. login
  3. -> error toast caused by budget-widget

image

What Is the New Behavior?

  • widget display only active if approval is activated.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

caused by #326

@dhhyi dhhyi added the bug Something isn't working label Jan 5, 2021
@dhhyi dhhyi added this to the 0.27 milestone Jan 5, 2021
@dhhyi dhhyi requested review from MaxKless, shauke and SGrueber January 5, 2021 21:35
@dhhyi dhhyi self-assigned this Jan 5, 2021
@shauke shauke merged commit 3bffb9a into develop Jan 6, 2021
@shauke shauke deleted the bugfix/error-b2c-login branch January 6, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

@MaxKless MaxKless Awaiting requested review from MaxKless

@SGrueber SGrueber Awaiting requested review from SGrueber

Assignees

@dhhyi dhhyi

Labels
bug Something isn't working
Projects
None yet
Milestone
0.27
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @shauke