Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Display purchaser box #486

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Dec 11, 2020

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

There is no purchaser info on checkout and order details page.

Issue Number: Closes #476

What Is the New Behavior?

There is a purchaser box on checkout review, checkout receipt and order details page.
The basket model service and NgRx store has been extended by methods to add, update and delete custom attribute on the basket,

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@SGrueber SGrueber requested review from shauke and M-Behr December 11, 2020 11:50
@SGrueber SGrueber self-assigned this Dec 11, 2020
@SGrueber SGrueber added the feature New feature or request label Dec 11, 2020
@SGrueber SGrueber added this to the 0.26 milestone Dec 11, 2020
@SGrueber SGrueber force-pushed the feature/basket_custom_attributes branch from cf9f1ae to 6a1d20b Compare December 11, 2020 12:12
@SGrueber SGrueber linked an issue Dec 11, 2020 that may be closed by this pull request
@SGrueber SGrueber force-pushed the feature/basket_custom_attributes branch from 6a1d20b to 1a97568 Compare December 14, 2020 08:39
@shauke shauke force-pushed the feature/requisition-management branch 2 times, most recently from 6061da3 to 9ddf65b Compare December 15, 2020 18:06
@shauke shauke force-pushed the feature/basket_custom_attributes branch from 1a97568 to a5af55d Compare December 16, 2020 12:37
@SGrueber SGrueber force-pushed the feature/basket_custom_attributes branch from a5af55d to a24ac1f Compare December 16, 2020 15:19
@shauke shauke force-pushed the feature/requisition-management branch from 3a37ed1 to beb81c7 Compare December 16, 2020 16:19
@shauke shauke force-pushed the feature/basket_custom_attributes branch from a24ac1f to dcfe3c2 Compare December 16, 2020 16:41
shauke
shauke previously approved these changes Dec 16, 2020
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the headline from Purchaser to Buyer (only for consistent naming).
Could you please check if the order of the data still matches in the e-mail? The buyer box has already been added to the e-mails with the approval feature.

@shauke
Copy link
Collaborator

shauke commented Dec 16, 2020

PWA
image

E-Mail
image

@SGrueber SGrueber force-pushed the feature/basket_custom_attributes branch 2 times, most recently from d31ee1b to 9f34132 Compare December 16, 2020 21:24
@SGrueber SGrueber requested a review from M-Behr December 16, 2020 21:29
M-Behr
M-Behr previously approved these changes Dec 17, 2020
Base automatically changed from feature/requisition-management to develop December 17, 2020 13:38
@shauke shauke dismissed M-Behr’s stale review December 17, 2020 13:38

The base branch was changed.

@shauke shauke dismissed their stale review December 17, 2020 13:38

The base branch was changed.

- add service and store functionality to add, update and remove basket custom attributes

closes #476
@shauke shauke force-pushed the feature/basket_custom_attributes branch from 9f34132 to 3dda47c Compare December 17, 2020 13:48
@shauke shauke merged commit 5f046c1 into develop Dec 17, 2020
@shauke shauke deleted the feature/basket_custom_attributes branch December 17, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom attributes to the basket, requisition and order models
3 participants