-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Display purchaser box #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
feature/basket_custom_attributes
branch
from
December 11, 2020 12:12
cf9f1ae
to
6a1d20b
Compare
SGrueber
force-pushed
the
feature/basket_custom_attributes
branch
from
December 14, 2020 08:39
6a1d20b
to
1a97568
Compare
shauke
force-pushed
the
feature/requisition-management
branch
2 times, most recently
from
December 15, 2020 18:06
6061da3
to
9ddf65b
Compare
shauke
force-pushed
the
feature/basket_custom_attributes
branch
from
December 16, 2020 12:37
1a97568
to
a5af55d
Compare
SGrueber
force-pushed
the
feature/basket_custom_attributes
branch
from
December 16, 2020 15:19
a5af55d
to
a24ac1f
Compare
shauke
force-pushed
the
feature/requisition-management
branch
from
December 16, 2020 16:19
3a37ed1
to
beb81c7
Compare
shauke
force-pushed
the
feature/basket_custom_attributes
branch
from
December 16, 2020 16:41
a24ac1f
to
dcfe3c2
Compare
shauke
previously approved these changes
Dec 16, 2020
M-Behr
requested changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the headline from Purchaser to Buyer (only for consistent naming).
Could you please check if the order of the data still matches in the e-mail? The buyer box has already been added to the e-mails with the approval feature.
SGrueber
force-pushed
the
feature/basket_custom_attributes
branch
2 times, most recently
from
December 16, 2020 21:24
d31ee1b
to
9f34132
Compare
M-Behr
previously approved these changes
Dec 17, 2020
- add service and store functionality to add, update and remove basket custom attributes closes #476
shauke
force-pushed
the
feature/basket_custom_attributes
branch
from
December 17, 2020 13:48
9f34132
to
3dda47c
Compare
shauke
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
There is no purchaser info on checkout and order details page.
Issue Number: Closes #476
What Is the New Behavior?
There is a purchaser box on checkout review, checkout receipt and order details page.
The basket model service and NgRx store has been extended by methods to add, update and delete custom attribute on the basket,
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information