-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve template related type compatibility #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
refactor/strict_templates_1
branch
from
November 2, 2020 08:32
37129d3
to
e595d05
Compare
dhhyi
force-pushed
the
refactor/strict_templates_1
branch
4 times, most recently
from
November 6, 2020 11:20
f61f070
to
313e5c1
Compare
dhhyi
force-pushed
the
refactor/strict_templates_1
branch
from
November 6, 2020 20:48
81b15c8
to
68031a5
Compare
dhhyi
force-pushed
the
refactor/strict_templates_1
branch
3 times, most recently
from
November 9, 2020 14:27
a9c829e
to
3002e21
Compare
…oting from line-item-list
dhhyi
force-pushed
the
refactor/strict_templates_1
branch
from
November 9, 2020 15:09
3002e21
to
4861060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the New Behavior?
Template related type compability has been improved.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information