Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display the region in the address form on the checkout address page #241

Merged
merged 1 commit into from
May 19, 2020

Conversation

SGrueber
Copy link
Collaborator

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

If the user edits an address on checkout address page the region is sometimes not or incorrectly displayed in the address form.

Issue Number: Closes #239

What Is the New Behavior?

If the user edits an address on checkout address page the region is correctly displayed in the address form.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@SGrueber SGrueber requested a review from dhhyi May 18, 2020 12:56
@SGrueber SGrueber self-assigned this May 18, 2020
@SGrueber SGrueber added the bug Something isn't working label May 18, 2020
@SGrueber SGrueber added this to the 0.20 milestone May 18, 2020
dhhyi
dhhyi previously approved these changes May 18, 2020
@SGrueber SGrueber force-pushed the bugfix/display_region_on_edit_address_form branch from a69b45b to 6d1080c Compare May 18, 2020 18:50
@dhhyi dhhyi self-requested a review May 19, 2020 06:42
@SGrueber SGrueber merged commit 7b8e1bf into develop May 19, 2020
@SGrueber SGrueber deleted the bugfix/display_region_on_edit_address_form branch May 19, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkout address page: region is sometimes not displayed in edit address mode
2 participants