fix: password check for user email update #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
changed the title
SGrueber
changed the title
SGrueber
approved these changes
Dec 16, 2024
SGrueber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
It is possible to change the e-mail address in the user profile of the My Account without correct password, while there is a need to enter the password. The password is sent in the request header of the user put request, but is is not checked by the ICM any more.
What Is the New Behavior?
The password is sent to the ICM in the request body of the user put request (updateUser method of the user.service.ts) now.
There the password is validated by the ICM when the user's email is changed.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Requires ICM 13.0, 12.3.1, or 7.10.41.7 or higher to fix this issue.
AD