fix: display product image twice on PDP #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this rule will be deprecated in Angular 18 and switched off by default after that.
* disable hydration for the product images carousel * because hydration causes an issue in combination with the swiper (image slider)
shauke
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[x] Other: eslint change
What Is the Current Behavior?
On a production-like deployed PWA (with SSR) the product image is shortly shown twice on product detail page. This is due to an hydration issue regarding the swiper (image slider).
Issue Number: Closes #
What Is the New Behavior?
The hydration is switched off for the product images component. This leads also to an improved performance (lighthouse score) for mobile devices.
The eslint rule '@angular-eslint/no-host-metadata-property' has been switched off because it will be deprecated with Angular 18.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#100538