refactor: replace options calls by appropriate get requests

src/app/core/services/api/api.service.spec.ts

@@ -64,6 +64,7 @@ describe('Api Service', () => {
     });
 
     it('should call the httpClient.options method when apiService.options method is called.', done => {
+      // eslint-disable-next-line etc/no-deprecated
       apiService.options('data').subscribe({
         next: data => {
           expect(data).toBeTruthy();
@@ -79,6 +80,7 @@ describe('Api Service', () => {
     it('should create Error Action if httpClient.options throws Error.', () => {
       const statusText = 'ERROR';
 
+      // eslint-disable-next-line etc/no-deprecated
       apiService.options('data').subscribe({ next: fail, error: fail });
       const req = httpTestingController.expectOne(`${REST_URL}/data`);
 

src/app/core/services/api/api.service.ts

@@ -217,8 +217,9 @@ export class ApiService {
     );
   }
 
+  // not-dead-code
   /**
-   * http options request
+   * @deprecated http options request - will be removed with the next major release (6.0)
    */
   options<T>(path: string, options?: AvailableOptions): Observable<T> {
     return this.execute(

src/app/core/services/payment/payment.service.spec.ts

@@ -214,23 +214,21 @@ describe('Payment Service', () => {
     it("should get a user's payment method data when 'getUserPaymentMethods' is called for b2c/b2x applications", done => {
       when(apiServiceMock.get(anyString())).thenReturn(of([]));
       when(apiServiceMock.resolveLinks()).thenReturn(() => of([]));
-      when(apiServiceMock.options(anyString())).thenReturn(of([]));
       const customer = {
         customerNo: '4711',
         isBusinessCustomer: false,
       } as Customer;
 
       paymentService.getUserPaymentMethods(customer).subscribe(() => {
         verify(apiServiceMock.get('customers/4711/payments')).once();
-        verify(apiServiceMock.options('customers/4711/payments')).once();
+        verify(apiServiceMock.get('customers/4711/eligible-payment-methods')).once();
         done();
       });
     });
 
     it("should get a user's payment method data when 'getUserPaymentMethods' is called for rest applications", done => {
       when(apiServiceMock.get(anyString())).thenReturn(of([]));
       when(apiServiceMock.resolveLinks()).thenReturn(() => of([]));
-      when(apiServiceMock.options(anyString())).thenReturn(of([]));
       when(appFacadeMock.customerRestResource$).thenReturn(of('privatecustomers'));
       const customer = {
         customerNo: '4711',
@@ -239,7 +237,7 @@ describe('Payment Service', () => {
 
       paymentService.getUserPaymentMethods(customer).subscribe(() => {
         verify(apiServiceMock.get('privatecustomers/4711/payments')).once();
-        verify(apiServiceMock.options('privatecustomers/4711/payments')).once();
+        verify(apiServiceMock.get('privatecustomers/4711/eligible-payment-methods')).once();
         done();
       });
     });

src/app/core/services/payment/payment.service.ts

@@ -289,7 +289,9 @@ export class PaymentService {
           this.apiService.resolveLinks<PaymentInstrumentData>(),
           concatMap(instruments =>
             this.apiService
-              .options(`${restResource}/${this.apiService.encodeResourceId(customer.customerNo)}/payments`)
+              // replace the get request by an options request if your ICM version is lower than 11.10.0
+              // .options(`${restResource}/${this.apiService.encodeResourceId(customer.customerNo)}/payments`)
+              .get(`${restResource}/${this.apiService.encodeResourceId(customer.customerNo)}/eligible-payment-methods`)
               .pipe(
                 unpackEnvelope<PaymentMethodOptionsDataType>('methods'),
                 map(methods => PaymentMethodMapper.fromOptions({ methods, instruments }))

src/app/extensions/punchout/services/punchout/punchout.service.spec.ts

@@ -22,7 +22,6 @@ describe('Punchout Service', () => {
     apiServiceMock = mock(ApiService);
     cookiesServiceMock = mock(CookiesService);
 
-    when(apiServiceMock.options(anything(), anything())).thenReturn(of({}));
     when(apiServiceMock.get(anything(), anything())).thenReturn(of({}));
     when(apiServiceMock.resolveLinks(anything())).thenReturn(() => of([]));
     when(apiServiceMock.post(anything(), anything(), anything())).thenReturn(of({}));
@@ -106,8 +105,8 @@ describe('Punchout Service', () => {
 
   it("should get oci options when 'getOciConfigurationOptions' is called", done => {
     punchoutService.getOciConfigurationOptions().subscribe(() => {
-      verify(apiServiceMock.options(anything(), anything())).once();
-      expect(capture(apiServiceMock.options).last()[0]).toMatchInlineSnapshot(`"customers/4711/punchouts/oci5"`);
+      verify(apiServiceMock.get(anything(), anything())).once();
+      expect(capture(apiServiceMock.get).last()[0]).toMatchInlineSnapshot(`"customers/4711/punchouts/oci5"`);
       done();
     });
   });

src/app/extensions/punchout/services/punchout/punchout.service.ts

@@ -514,7 +514,8 @@ export class PunchoutService {
     return this.currentCustomer$.pipe(
       switchMap(customer =>
         this.apiService
-          .options<OciOptionsData>(
+          // replace the get request by an options request if your ICM version is lower than 12.2.1
+          .get<OciOptionsData>(
             `customers/${this.apiService.encodeResourceId(customer.customerNo)}/punchouts/${this.getResourceType(
               'oci'
             )}`,