refactor: anchors with empty routerLink converted to buttons #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilaraGueler
changed the title
DilaraGueler
changed the title
DilaraGueler
added
bug
|
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/anchors_to_buttons
branch
from
55eb2e3 to
adcbeef
Compare
|
Azure Demo Servers are available: |
|
Azure Demo Servers are available: |
|
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/anchors_to_buttons
branch
from
d04beab to
38afabe
Compare
SGrueber
force-pushed
the
feature/anchors_to_buttons
branch
from
38afabe to
f475590
Compare
SGrueber
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[X] Bugfix
[] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[X] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
For accessibility reasons, at many links a [routerLink]="[]" attribute is defined to ensure they were clickable. However, after the Angular 16 update, this approach often results in an unintended page scroll, causing the page to jump to the top.
The assigned issue regarding the 'show all/show less' link in the facet filter is related to the used empty routerlink at the anchor tag.
Issue Number: Closes #1572
What Is the New Behavior?
If links don't navigate the user to a new page but trigger only an action the
<button>html element is used instead of an anchor tag and the css styling has been adapted accordingly. Use css classesbtn btn-link btn-link-actionfor text links andbtn-tool btn-linkfor icon links. Buttons inherently provide better support for keyboard interactions and enhance overall accessibility.Issue #1572: To fix this issue use a button html tag instead of an anchor tag and design it as a link. Remove its
routerLinkattribute.Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information
AB#93480