refactor: fetching eligible basket addresses #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
added
refactoring
SGrueber
force-pushed
the
refactor/basket_eligible_addresses
branch
from
d3bc119 to
56bf108
Compare
SGrueber
force-pushed
the
refactor/basket_eligible_addresses
branch
from
56bf108 to
73aca11
Compare
SGrueber
changed the title
shauke
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
If the user enters the checkout shipping page customer addresses were requested by the ICM. The result list contains a link list, so for each address a detail call has to be triggered. In case of many customer addresses this behavior causes a performance issue.
Relates to issue number: #1528
What Is the New Behavior?
Now the REST call get /baskets//eligible-addresses is used to show addresses on checkout address page.
All address information is returned by this call so there are no further requests necessary.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#92525