Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: edit attributes in basket page #1508

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

skoch-intershop
Copy link
Contributor

@skoch-intershop skoch-intershop commented Sep 12, 2023

First image shows the basket page in regards of the current implementation. The first line item already contains values for partial order number and customer product id. The values are displayed as text and also the link Show more is displayed.
Clicking on this link opens a form for editing the two values. The second line item does not contain values for partial order number and customer product id. The initial form is loaded as soon as the Show more link is pressed. As long as no values are entered, the Apply button is disabled and the Cancel button is hidden.
image

The second image shows the input of a value into the input field. In this case the Apply button and the Cancel button are now active. The Apply button submit the form, Form will closed and new values will displayed as text. Pressing the Cancel button will also close the form.
image

The last image shows an example of a line item list of an order:
image

releated issue: 88568

IAD Proposal: https://www.figma.com/file/kI5YJizwgiN62g3oP4WCJT/Commissioning-number-%26-Customer-product-ID-fields?type=design&node-id=0-1&mode=design

@SGrueber SGrueber changed the title #88568: edit attributes in basket page feature: edit attributes in basket page Sep 13, 2023
@dhhyi dhhyi force-pushed the feature/extended-line-item-attributes-on-basket-page branch from 71345d4 to d1f8ddd Compare November 14, 2023 13:15
@dhhyi dhhyi force-pushed the feature/extended-line-item-attributes-on-basket-page branch 5 times, most recently from 97b50c7 to 461ac20 Compare November 29, 2023 12:50
@dhhyi
Copy link
Collaborator

dhhyi commented Nov 29, 2023

Now using ish-in-place-edit, which was preferred by the customer. Also using server configuration from configurations call.

image

@dhhyi
Copy link
Collaborator

dhhyi commented Dec 5, 2023

Needs rework using customFields API

@shauke shauke added this to the 5.0 milestone Dec 13, 2023
@shauke shauke self-assigned this Dec 13, 2023
@SGrueber SGrueber self-requested a review December 15, 2023 13:46
@shauke shauke modified the milestones: 5.0, 5.1 Dec 15, 2023
@SGrueber SGrueber force-pushed the feature/extended-line-item-attributes-on-basket-page branch from 461ac20 to b3756df Compare December 15, 2023 16:43
@SGrueber SGrueber added enhancement Enhancement to an existing feature wait Waiting for something (e.g. new ICM release) and removed has conflicts labels Dec 15, 2023
@SGrueber
Copy link
Collaborator

PR will possibly replaced by a customFields implementation

@shauke shauke force-pushed the feature/extended-line-item-attributes-on-basket-page branch from b3756df to e1d1f9a Compare January 22, 2024 09:10
Copy link

Azure Demo Servers are available:

@shauke shauke removed this from the 5.1 milestone Mar 13, 2024
@shauke shauke added this to the 5.2 milestone Mar 13, 2024
@shauke shauke modified the milestones: 5.2, 5.3 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature has conflicts wait Waiting for something (e.g. new ICM release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants