Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: product warranties #1368

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat: product warranties #1368

merged 1 commit into from
Apr 25, 2024

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Feb 7, 2023

PR Type

[x] Feature

What Is the Current Behavior?

The PWA does not yet handle product warranties.

Issue Number: Closes #1062

What Is the New Behavior?

The user is able to buy a product together with a warranty. He/she can select a warranty on the product detail page and the cart page. The selected warranties are shown during the checkout process and on requisition and order detail pages.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Limitations

The PR requires an ICM 11.7 or higher.

With lower ICM versions the following issues are known:
If the user removes a warranty from a basket line item the basket calculation is not promptly triggered.
After submitting an order that contains a product with a warranty a general error page is shown. AB#80443
This causes the current e2e-test to fail.

Once the order process can be finished, additional e2e-tests for the receipt page and order-detail page have to be added.
These issues will be fixed in ICM 7.10.41.

If the user changes the shipping method the basket cannot be ordered any more due to limitations of the ICM REST interface.
To overcome this problem the ICM has to be configured to use single shipment only.

Other Information

IAD: https://www.figma.com/file/4ApE1rE1fsjaKyrUtd90Rd/Product-Warranties?node-id=0%3A1

Pending UI Issues:

  • display warranty name (isntead of id) in the basket items overview of the checkout side bar
  • display single warranty price in the line items list

AB#83337

@shauke shauke added this to the 4.0 milestone Feb 7, 2023
@shauke shauke requested a review from SGrueber February 7, 2023 10:56
@SGrueber SGrueber force-pushed the feature/product_warranties branch 2 times, most recently from 2f4fb42 to c1c293a Compare February 17, 2023 11:44
@SGrueber SGrueber marked this pull request as draft February 17, 2023 12:14
@SGrueber SGrueber force-pushed the feature/product_warranties branch from e609106 to 0d9eede Compare February 22, 2023 15:38
@SGrueber SGrueber marked this pull request as ready for review February 24, 2023 09:06
@github-actions
Copy link

Azure Demo Servers are available:

@SGrueber SGrueber marked this pull request as draft February 27, 2023 10:08
@SGrueber SGrueber marked this pull request as ready for review March 9, 2023 12:44
@SGrueber SGrueber added the feature New feature or request label Mar 9, 2023
@SGrueber SGrueber modified the milestones: 4.0, 4.1 Mar 9, 2023
@SGrueber SGrueber added the wait Waiting for something (e.g. new ICM release) label Mar 9, 2023
@LucasHengelhaupt LucasHengelhaupt force-pushed the feature/product_warranties branch from 14dccf9 to eaf02f4 Compare March 16, 2023 14:38
@github-actions
Copy link

Azure Demo Servers are available:

@shauke shauke modified the milestones: 4.1, 4.2 Jun 1, 2023
@stxppxr stxppxr modified the milestones: 4.2, 5.0 Aug 30, 2023
@shauke shauke modified the milestones: 5.0, 5.1 Dec 13, 2023
@SGrueber SGrueber force-pushed the feature/product_warranties branch from ba05860 to e257e18 Compare December 13, 2023 10:04
@SGrueber SGrueber force-pushed the feature/product_warranties branch from e257e18 to c42ae0d Compare January 2, 2024 10:54
@SGrueber SGrueber removed wait Waiting for something (e.g. new ICM release) has conflicts labels Jan 2, 2024
@SGrueber SGrueber force-pushed the feature/product_warranties branch from a3003ed to d6c9ae2 Compare January 8, 2024 11:11
@SGrueber SGrueber requested a review from marschmidt89 January 8, 2024 11:13
Copy link

github-actions bot commented Jan 8, 2024

Azure Demo Servers are available:

schadii
schadii previously approved these changes Jan 8, 2024
iwiederhold
iwiederhold previously approved these changes Jan 8, 2024
@marschmidt89 marschmidt89 removed their request for review January 11, 2024 11:58
@SGrueber SGrueber requested a review from a team January 11, 2024 12:21
@marschmidt89 marschmidt89 dismissed stale reviews from iwiederhold and schadii via 082e052 January 12, 2024 16:45
@marschmidt89 marschmidt89 requested a review from mglatter January 12, 2024 16:55
@mglatter
Copy link
Contributor

I will change the English wording to the suggestions agreed on with Shadi and will provide updated localization values for the other languages as well.

mglatter
mglatter previously approved these changes Jan 17, 2024
@shauke shauke modified the milestones: 5.1, 5.2 Mar 14, 2024
@SGrueber SGrueber force-pushed the feature/product_warranties branch from b762cf7 to f796564 Compare April 16, 2024 14:27
@shauke shauke force-pushed the feature/product_warranties branch from f796564 to f849a75 Compare April 24, 2024 16:13
@shauke shauke self-assigned this Apr 24, 2024
@shauke shauke force-pushed the feature/product_warranties branch from f849a75 to bba010b Compare April 25, 2024 08:53
Co-authored-by: Silke <s.grueber@intershop.de>
@shauke shauke force-pushed the feature/product_warranties branch from bba010b to e6e26d0 Compare April 25, 2024 10:41
@shauke shauke merged commit bb952bd into develop Apr 25, 2024
12 checks passed
@shauke shauke deleted the feature/product_warranties branch April 25, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Warranties
7 participants