-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: product warranties #1368
Merged
Merged
feat: product warranties #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
feature/product_warranties
branch
2 times, most recently
from
February 17, 2023 11:44
2f4fb42
to
c1c293a
Compare
SGrueber
force-pushed
the
feature/product_warranties
branch
from
February 22, 2023 15:38
e609106
to
0d9eede
Compare
Azure Demo Servers are available: |
LucasHengelhaupt
force-pushed
the
feature/product_warranties
branch
from
March 16, 2023 14:38
14dccf9
to
eaf02f4
Compare
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/product_warranties
branch
from
December 13, 2023 10:04
ba05860
to
e257e18
Compare
SGrueber
force-pushed
the
feature/product_warranties
branch
from
January 2, 2024 10:54
e257e18
to
c42ae0d
Compare
SGrueber
force-pushed
the
feature/product_warranties
branch
from
January 8, 2024 11:11
a3003ed
to
d6c9ae2
Compare
Azure Demo Servers are available: |
schadii
previously approved these changes
Jan 8, 2024
iwiederhold
previously approved these changes
Jan 8, 2024
marschmidt89
dismissed stale reviews from iwiederhold and schadii
via
January 12, 2024 16:45
082e052
mglatter
reviewed
Jan 15, 2024
mglatter
reviewed
Jan 15, 2024
mglatter
reviewed
Jan 15, 2024
I will change the English wording to the suggestions agreed on with Shadi and will provide updated localization values for the other languages as well. |
mglatter
previously approved these changes
Jan 17, 2024
SGrueber
force-pushed
the
feature/product_warranties
branch
from
April 16, 2024 14:27
b762cf7
to
f796564
Compare
shauke
force-pushed
the
feature/product_warranties
branch
from
April 24, 2024 16:13
f796564
to
f849a75
Compare
shauke
force-pushed
the
feature/product_warranties
branch
from
April 25, 2024 08:53
f849a75
to
bba010b
Compare
Co-authored-by: Silke <s.grueber@intershop.de>
shauke
force-pushed
the
feature/product_warranties
branch
from
April 25, 2024 10:41
bba010b
to
e6e26d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
The PWA does not yet handle product warranties.
Issue Number: Closes #1062
What Is the New Behavior?
The user is able to buy a product together with a warranty. He/she can select a warranty on the product detail page and the cart page. The selected warranties are shown during the checkout process and on requisition and order detail pages.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Limitations
The PR requires an ICM 11.7 or higher.
With lower ICM versions the following issues are known:
If the user removes a warranty from a basket line item the basket calculation is not promptly triggered.
After submitting an order that contains a product with a warranty a general error page is shown. AB#80443
This causes the current e2e-test to fail.
Once the order process can be finished, additional e2e-tests for the receipt page and order-detail page have to be added.
These issues will be fixed in ICM 7.10.41.
If the user changes the shipping method the basket cannot be ordered any more due to limitations of the ICM REST interface.
To overcome this problem the ICM has to be configured to use single shipment only.
Other Information
IAD: https://www.figma.com/file/4ApE1rE1fsjaKyrUtd90Rd/Product-Warranties?node-id=0%3A1
Pending UI Issues:
AB#83337