fix: change password redirects to login page on success #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Haehnlein
force-pushed
the
bugfix/forgot-password-to-login-page
branch
from
89bac71 to
16e00e7
Compare
dhhyi
requested changes
Feb 26, 2020
dhhyi
previously approved these changes
Feb 27, 2020
Wow, I was under the impression that the password change already logs in the customer, which in my mind would be the only logical thing to do. Turns out I was wrong. So yeah, you're right with the suggested solution. 😅 👍 |
Sebastian-Haehnlein
force-pushed
the
bugfix/forgot-password-to-login-page
branch
from
16e00e7 to
604bd01
Compare
dhhyi
previously approved these changes
Feb 28, 2020
shauke
requested changes
Mar 2, 2020
src/app/pages/forgot-password/update-password/update-password.component.ts
Outdated
Show resolved
Hide resolved
Sebastian-Haehnlein
force-pushed
the
bugfix/forgot-password-to-login-page
branch
from
604bd01 to
2bfdab6
Compare
dhhyi
approved these changes
Mar 2, 2020
shauke
approved these changes
Mar 2, 2020
cbratsch
pushed a commit
that referenced
this pull request
Mar 9, 2020
…splaying the login dialog (#130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
change password (forgot password) open login dialog on success
What Is the New Behavior?
change password (forgot password) redirects to login page on success
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information