feat: interprets the relative URLs of pagelet parameters "bc_pmc:type… #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.pagelet2-ImageFileRef" generically Until now only parameter that starts with image or video were interpreted Now any parameter that extends "bc_pmc:types.pagelet2-ImageFileRef" will be interpreted
jometzner
reviewed
Jul 21, 2022
...app/core/models/content-configuration-parameter/content-configuration-parameter.interface.ts
Outdated
Show resolved
Hide resolved
… presence of that property
|
Nice. Thank you. I suppose this is finally the fix for #385. 😉 |
|
I add FileRef support. |
|
We can take care of this in our review. Thank you for your effort. |
jometzner
reviewed
Jul 29, 2022
src/app/core/models/content-configuration-parameter/content-configuration-parameter.mapper.ts
Outdated
Show resolved
Hide resolved
jometzner
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s.pagelet2-ImageFileRef" generically
Until now only parameter that starts with image or video were interpreted
Now any parameter that
extends "bc_pmc:types.pagelet2-ImageFileRef" will be interpreted
PR Type
[ ] Bugfix
[ X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Issue Number: Closes #385
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ X ] Yes
[ ] No
The CMS configuration parameter model now has a mandatory
typeparameter. If you have been writing Jest tests involving configuration parameter values, you have to add any giventypevalue.Other Information