Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: design preview support #1216

Merged
merged 2 commits into from
Jan 16, 2023
Merged

feat: design preview support #1216

merged 2 commits into from
Jan 16, 2023

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Jul 18, 2022

PR Type

[x] Feature

What Is the New Behavior?

Initial Design Preview support (!!! NOT Design View with editing capabilities !!!)

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#78271

@shauke shauke added this to the 3.0 milestone Jul 18, 2022
@jometzner jometzner force-pushed the feature/design_preview branch from d0d355f to 878146a Compare July 25, 2022 08:33
@jometzner jometzner marked this pull request as ready for review July 25, 2022 11:37
@jometzner jometzner requested review from Eisie96 and MaxKless July 25, 2022 12:26
@jometzner
Copy link
Collaborator

PreviewInterceptor is not SSR compatible. Session Storage reference doesn't work

@shauke shauke added the wait Waiting for something (e.g. new ICM release) label Aug 8, 2022
@shauke shauke removed this from the 3.0 milestone Aug 8, 2022
@shauke
Copy link
Collaborator Author

shauke commented Aug 8, 2022

Waiting for an ICM release that contains the necessary changes on ICM side for the Design Preview for the headless application type.

@jometzner jometzner force-pushed the feature/design_preview branch from a6cf5f5 to 4a6b98c Compare August 11, 2022 15:23
@jometzner jometzner force-pushed the feature/design_preview branch from 4a6b98c to 6743f02 Compare August 26, 2022 11:36
src/app/core/services/preview/preview.service.ts Outdated Show resolved Hide resolved
src/app/core/services/preview/preview.service.ts Outdated Show resolved Hide resolved
src/app/core/services/preview/messages.ts Outdated Show resolved Hide resolved
@shauke
Copy link
Collaborator Author

shauke commented Dec 9, 2022

Requires ICM 7.10.39.1 once it is GA.

@shauke shauke added this to the 3.3 milestone Dec 9, 2022
@shauke shauke removed the request for review from MaxKless January 3, 2023 09:14
@Eisie96 Eisie96 force-pushed the feature/design_preview branch from 6743f02 to 353c039 Compare January 5, 2023 10:49
@github-actions
Copy link

Azure Demo Servers are available:

1 similar comment
@github-actions
Copy link

Azure Demo Servers are available:

* needs to stay http as long as the used ICM is configured with http since it has no valid certificate

This reverts commit 3b48c0f.
shauke added a commit that referenced this pull request Jan 16, 2023
* PreviewContextID interceptor adds PreviewContextID to REST calls
* PreviewService for PreviewContextID handling (set, update, delete)
* changed `{ path: '', redirectTo: 'home', pathMatch: 'full' }` to prevent PreviewContextID query parameter is removed on redirect for empty route path
* documentation (NOT full Design View)

Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de>
@shauke shauke force-pushed the feature/design_preview branch from 26b22d9 to 694a338 Compare January 16, 2023 17:29
marschmidt89
marschmidt89 previously approved these changes Jan 16, 2023
Copy link
Contributor

@marschmidt89 marschmidt89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation changes approved

* PreviewContextID interceptor adds PreviewContextID to REST calls
* PreviewService for PreviewContextID handling (set, update, delete)
* changed `{ path: '', redirectTo: 'home', pathMatch: 'full' }` to prevent PreviewContextID query parameter is removed on redirect for empty route path
* documentation (NOT full Design View)

Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de>
@shauke shauke force-pushed the feature/design_preview branch from d0a6f4b to 5c73145 Compare January 16, 2023 19:45
@shauke shauke merged commit 8a22f3c into develop Jan 16, 2023
@shauke shauke deleted the feature/design_preview branch January 16, 2023 20:11
@shauke shauke removed the wait Waiting for something (e.g. new ICM release) label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants