Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make default favicon accessible from root #1199

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jun 29, 2022

PR Type

[x] Bugfix

What Is the Current Behavior?

Issue Number: Closes #1194

What Is the New Behavior?

favicon.ico is accessible from website root.
If used with context path multi-site, only the default brand favicon can be chosen. If used with domain multi-site, the correct favicon is chosen automatically.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#77775

@dhhyi dhhyi added bug Something isn't working community Community contributions labels Jun 29, 2022
@dhhyi dhhyi requested a review from jometzner June 29, 2022 12:03
@dhhyi dhhyi marked this pull request as ready for review June 29, 2022 12:20
@jometzner jometzner self-assigned this Jul 11, 2022
@jometzner jometzner removed their assignment Jul 11, 2022
@jometzner jometzner merged commit 2cda276 into develop Jul 11, 2022
@jometzner jometzner deleted the fix/default-favicon branch July 11, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community Community contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Favorite Icon spawns error with latest Vivaldi
2 participants