Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUESTION] SEO locales #69

Closed
nickyhaze opened this issue Dec 18, 2019 · 1 comment · Fixed by #72
Closed

[QUESTION] SEO locales #69

nickyhaze opened this issue Dec 18, 2019 · 1 comment · Fixed by #72
Assignees
@Sebastian-Haehnlein @rkarl-ish
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@nickyhaze
Copy link
Contributor

nickyhaze commented Dec 18, 2019 •
edited
Loading

I'm currently using the "seo.title.home" in the app-routing-module.ts.

It's always showing me the "en_US" translation as my title. The weird thing is that I expect to see another translated title here ("nl_NL") since I'm also seeing my other translations perfectly fine in my components while using the translate pipe.

Am I forgetting to set a default language somewhere? Or are the seo related things always looking at "en_US"?

I have defined my own language "nl_NL" inside all my environments as the first locale.

Thank you in advance.
@nickyhaze nickyhaze added the bug Something isn't working label Dec 18, 2019
@nickyhaze nickyhaze changed the title [QUESTION] [QUESTION] SEO locales Dec 18, 2019
@Sebastian-Haehnlein Sebastian-Haehnlein self-assigned this Dec 18, 2019
@Sebastian-Haehnlein
Copy link
Contributor

we can reproduce this bug, i will provide a pullrequest asap

@Sebastian-Haehnlein Sebastian-Haehnlein added the help wanted Extra attention is needed label Dec 18, 2019
Sebastian-Haehnlein added a commit that referenced this issue Dec 18, 2019
@Sebastian-Haehnlein
fix: ngx-meta translate #69
05ec722
@Sebastian-Haehnlein Sebastian-Haehnlein mentioned this issue Dec 18, 2019
Merged
Sebastian-Haehnlein added a commit that referenced this issue Dec 18, 2019
@Sebastian-Haehnlein
fix: ngx-meta translate #69 (#72)
b77a3ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebastian-Haehnlein Sebastian-Haehnlein

@rkarl-ish rkarl-ish

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ngx-meta translate on load is not working intershop/intershop-pwa
3 participants
@nickyhaze @Sebastian-Haehnlein @rkarl-ish