Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miss-matched current url host with actual page host #128

Closed
anumang opened this issue Feb 25, 2020 · 0 comments · Fixed by #138
Closed

miss-matched current url host with actual page host #128

anumang opened this issue Feb 25, 2020 · 0 comments · Fixed by #138
Assignees
Labels
bug Something isn't working
Milestone

Comments

@anumang
Copy link
Contributor

anumang commented Feb 25, 2020

Actual Behavior
At app.facede.js, currentUrl$ pipe not evaluating correct url if page hosted in domain origin other than 'icmBaseURL' rest origin.

Expected Behavior
currentUrl$ should be generated with actual hosted page origin. Like window.location.origin.

Steps to Reproduce the Bug

Steps to reproduce the behavior:

  1. Try on instance hosting url and rest API management url's are differs,
  2. Go to any product detail page with share with mail link activated,
  3. Click mail to icon,
  4. See product url contains rest url origin instead of actual page at mail body

Environment Details

*Desktop:

  • OS: MacOS
  • Browser: Chrome
  • Project Code Version: 0.16.1

Additional Context, like Screenshots, Log File Snippets etc.

currentUrl$ = this.store.pipe(
select(getICMBaseURL),
map(baseUrl => baseUrl + this.location.path())
);

@anumang anumang added the bug Something isn't working label Feb 25, 2020
@anumang anumang changed the title Miss-matched current url host with actual page host miss-matched current url host with actual page host Feb 25, 2020
@dhhyi dhhyi assigned dhhyi and unassigned rkarl-ish Mar 2, 2020
@dhhyi dhhyi added this to the 0.18 milestone Mar 2, 2020
dhhyi added a commit that referenced this issue Mar 2, 2020
- removed currentUrl$ from AppFacade
- use document.URL for sharing link

Closes #128
shauke pushed a commit that referenced this issue Mar 2, 2020
- removed currentUrl$ from AppFacade
- use document.URL for sharing link

Closes #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants