fix: click on image of image-text-button triggers change

intershop · Aug 26, 2020 · d7da542 · d7da542 · github-actions · Aug 26, 2020
1 parent 2a60f9d
commit d7da542
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/...tacton/pages/configure/tacton-image-text-buttons/tacton-image-text-buttons.component.html b/...tacton/pages/configure/tacton-image-text-buttons/tacton-image-text-buttons.component.html
@@ -1,7 +1,7 @@
 <div class="d-flex flex-wrap align-items-end pb-2">
   <div *ngFor="let opt of parameter.domain?.elements" class="mr-3">
     <div class="border" [ngClass]="{ 'border-primary': opt.selected }">
-      <img [src]="getImageUrl(opt.properties.tc_component_picture) | async" />
+      <img [src]="getImageUrl(opt.properties.tc_component_picture) | async" (click)="change(opt.name)" />
     </div>
     <label>
       <input

diff --git a/...ton/pages/configure/tacton-image-text-buttons/tacton-image-text-buttons.component.spec.ts b/...ton/pages/configure/tacton-image-text-buttons/tacton-image-text-buttons.component.spec.ts
@@ -94,10 +94,19 @@ describe('Tacton Image Text Buttons Component', () => {
     fixture.detectChanges();
 
     const input = fixture.debugElement.query(By.css('input')).nativeElement;
-    input.value = '3';
+    input.value = component.parameter.domain.elements[1].name;
     input.dispatchEvent(new Event('change'));
 
     verify(tactonFacade.commitValue(anything(), anything())).once();
-    expect(capture(tactonFacade.commitValue).last()[1]).toMatchInlineSnapshot(`"3"`);
+    expect(capture(tactonFacade.commitValue).last()[1]).toMatchInlineSnapshot(`"i2"`);
+  });
+
+  it('should trigger value commit if clicked on image', () => {
+    fixture.detectChanges();
+
+    fixture.debugElement.queryAll(By.css('img'))[1].triggerEventHandler('click', undefined);
+
+    verify(tactonFacade.commitValue(anything(), anything())).once();
+    expect(capture(tactonFacade.commitValue).last()[1]).toMatchInlineSnapshot(`"i2"`);
   });
 });