Skip to content

Commit

Permalink
chore: update required/tested Node.js version to 14.15.0 LTS (includi…
Browse files Browse the repository at this point in the history
…ng npm 6.14.8) (456)

BREAKING CHANGE: required Node.js version 14.15.0 LTS (including npm 6.14.8)
  • Loading branch information
shauke committed Nov 11, 2020
1 parent 906a5b4 commit 9a64080
Show file tree
Hide file tree
Showing 14 changed files with 38 additions and 34 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/dead-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
with:
fetch-depth: 0

- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/development.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand Down Expand Up @@ -73,10 +73,10 @@ jobs:
with:
fetch-depth: 0

- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand All @@ -94,10 +94,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand All @@ -117,10 +117,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
with:
fetch-depth: 0

- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand All @@ -61,10 +61,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Download Build Output
uses: actions/download-artifact@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/updates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install root dependencies
run: npm ci
Expand All @@ -42,10 +42,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14

- name: Install Clean Repository
run: |
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:12-alpine as buildstep
FROM node:14-alpine as buildstep
WORKDIR /workspace
COPY schematics /workspace/schematics/
COPY package.json package-lock.json /workspace/
Expand All @@ -21,7 +21,7 @@ RUN test "${serviceWorker}" = "true" && sed -i 's/canonicalHash !== cacheBustedH
RUN egrep -o '^\s*(mockServerAPI: true|mustMockPaths)' src/environments/environment.prod.ts || rm -Rf dist/browser/assets/mock*
COPY dist/entrypoint.sh dist/healthcheck.js dist/server.crt dist/server.key dist/robots.txt* /workspace/dist/

FROM node:12-alpine
FROM node:14-alpine
COPY --from=buildstep /workspace/dist /dist
ARG displayVersion=
LABEL displayVersion="${displayVersion}"
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile_reports
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:12 as reporting
FROM node:14 as reporting
COPY package.json package-lock.json tsconfig.base.json /workspace/
COPY tslint-rules /workspace/tslint-rules/
WORKDIR /workspace
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ kb_sync_latest_only
# Getting Started

Before working with this project, download and install [Node.js](https://nodejs.org) with the included npm package manager.
Currently Node.js 12.x LTS with the corresponding npm is required.
Currently Node.js 14.x LTS with the corresponding npm is required.

This project was generated with [Angular CLI](https://github.com/angular/angular-cli) and follows the Angular CLI style guide and naming conventions.

Expand Down
4 changes: 4 additions & 0 deletions docs/guides/migrations.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ kb_sync_latest_only

# Migrations

## 0.25 to 0.26

The project configuration was updated to use and test with Node.js version 14.15.0 LTS (including npm 6.14.8) for any further development.

## 0.24 to 0.25

We replaced the simple [ngx-cookie-banner](https://github.com/exportarts/ngx-cookie-banner) cookie banner with an own implementation that provides the means to configure and set more fine grained cookie consent options.
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"intershop"
],
"engines": {
"node": ">=12.13.0",
"npm": "~6.12.0"
"node": ">=14.15.0",
"npm": ">=6.14.8"
},
"private": true,
"scripts": {
Expand Down Expand Up @@ -106,7 +106,7 @@
"@types/express": "^4.17.8",
"@types/jest": "^26.0.15",
"@types/lodash-es": "^4.17.3",
"@types/node": "^12.19.2",
"@types/node": "^14.14.7",
"codelyzer": "^6.0.1",
"comment-json": "^4.1.0",
"commitizen": "^4.2.2",
Expand Down
2 changes: 1 addition & 1 deletion templates/Dockerfile_dev
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:12 as buildstep
FROM node:14 as buildstep
COPY . /workspace/
WORKDIR /workspace
RUN npm ci
Expand Down
2 changes: 1 addition & 1 deletion tslint-rules/src/ishUsefulImportsRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class Rule extends Lint.Rules.AbstractRule {
constructor(options: Lint.IOptions) {
super(options);
try {
const config = parse(fs.readFileSync('./tsconfig.base.json', { encoding: 'UTF-8' }));
const config = parse(fs.readFileSync('./tsconfig.base.json', { encoding: 'utf-8' }));
if (config && config.compilerOptions && config.compilerOptions.paths) {
const paths = config.compilerOptions.paths;
this.shortImports = Object.keys(paths).map(key => ({
Expand Down

0 comments on commit 9a64080

Please sign in to comment.