fix: display localized product attribute names (#91, #107)

closes: #91
intershop · Feb 11, 2020 · 3205ba5 · 3205ba5
1 parent da50347
commit 3205ba5
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/app/core/models/product/product.mapper.spec.ts b/src/app/core/models/product/product.mapper.spec.ts
@@ -114,6 +114,26 @@ describe('Product Mapper', () => {
       expect(product.type).toEqual('RetailSet');
       expect(ProductHelper.isRetailSet(product)).toBeTrue();
     });
+
+    it('should return attributes or detailed product attributes when PRODUCT_DETAIL_ATTRIBUTES enabled', () => {
+      const p1: Product = productMapper.fromData({
+        sku: '1',
+        attributes: [{ name: 'Graphics', type: 'String', value: 'NVIDIA Quadro K2200' }],
+      } as ProductData);
+      const p2: Product = productMapper.fromData(({
+        sku: '1',
+        attributes: [{ name: 'Graphics', type: 'String', value: 'NVIDIA Quadro K2200' }],
+        attributeGroups: {
+          PRODUCT_DETAIL_ATTRIBUTES: {
+            attributes: [{ name: 'Grafikkarte', type: 'String', value: 'NVIDIA Quadro K2200' }],
+          },
+        },
+      } as unknown) as ProductData);
+      expect(p1).toBeTruthy();
+      expect(p1.attributes).toEqual([{ name: 'Graphics', type: 'String', value: 'NVIDIA Quadro K2200' }]);
+      expect(p2).toBeTruthy();
+      expect(p2.attributes).toEqual([{ name: 'Grafikkarte', type: 'String', value: 'NVIDIA Quadro K2200' }]);
+    });
   });
 
   describe('fromStubData', () => {

diff --git a/src/app/core/models/product/product.mapper.ts b/src/app/core/models/product/product.mapper.ts
@@ -188,7 +188,11 @@ export class ProductMapper {
       minOrderQuantity: data.minOrderQuantity || 1,
       packingUnit: data.packingUnit,
       maxOrderQuantity: data.maxOrderQuantity || 100,
-      attributes: data.attributes,
+      attributes:
+        (data.attributeGroups &&
+          data.attributeGroups.PRODUCT_DETAIL_ATTRIBUTES &&
+          data.attributeGroups.PRODUCT_DETAIL_ATTRIBUTES.attributes) ||
+        data.attributes,
       attributeGroups: data.attributeGroups,
       images: this.imageMapper.fromImages(data.images),
       listPrice: filterPrice(data.listPrice),