Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak gitpod coverstore env file to support older docker versions #9876

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Sep 13, 2024

Closes #

Technical

Testing

Screenshot

Stakeholders

@RayBB

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test test it right now as I'm out but the approach looks like it should work :)

@cdrini
Copy link
Collaborator Author

cdrini commented Sep 13, 2024

Ok then going to merge this in to unbreak cases with the old version 👍 If you get the chance later give it a whirl on gitpod to double check that it works! Gitpod is a bit hit and miss for me on whether it starts up, so harder for me to test

@cdrini cdrini merged commit d026833 into internetarchive:master Sep 13, 2024
3 checks passed
@cdrini cdrini deleted the tweak-gitpod-env branch September 13, 2024 15:21
@RayBB
Copy link
Collaborator

RayBB commented Sep 13, 2024

@cdrini confirmed it's still working on gitpod :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants