Add check to daily new comments digest #9823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
changed the title
comments before accessing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
filter_issuesfunction to skip issues when list fetched from the comments URL is empty.Technical
Early in the issue filtering flow, we drop issues that have a
commentscount of0. It appears that it is possible for an issue to have a positive comment count, but not have comments. This code change drops such issues when such cases are encountered.Here are archived API responses for one such issue, and its comments.
Testing
The results of running these changes manually can be seen here. After running, the digest was published to our Slack channel.
Screenshot
Stakeholders