Add Library of Congress NAF as Author identifier #9812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Library of Congress Name Authority File (LC NAF) as an Author identifier. The `label` has been shortened to just “Library of Congress” to avoid having an obscenely long label in the drop-down lists and also avoid obscure acronyms (“NAF”) in it that are likely to cause more confusion than clarity. The URI identifiers given by LoC themselves start with “http://” but I have opted to use “https://” for the `url` so patrons etc. won’t need a redirect or similar to get to the page. Closes internetarchive#9791
Adds an entry for `loc_naf` (Library of Congress Name Authority File) identifiers to the `identifierPatterns` lookup table to enable autoselection when entering the identifiers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9812 +/- ##
==========================================
+ Coverage 16.06% 16.45% +0.39%
==========================================
Files 90 91 +1
Lines 4769 4897 +128
Branches 832 853 +21
==========================================
+ Hits 766 806 +40
- Misses 3480 3557 +77
- Partials 523 534 +11 ☔ View full report in Codecov by Sentry. |
tfmorris
suggested changes
Aug 28, 2024
Per internetarchive#9812 (comment) Co-authored-by: Tom Morris <tfmorris@gmail.com>
Per internetarchive#9812 (comment) Co-authored-by: Tom Morris <tfmorris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9791
feature
Technical
Adds Library of Congress Name Authority File (LC NAF) as an Author identifier in
author/identifiers.yml.The
labelhas been shortened to just “Library of Congress” to avoid having an obscenely long label in the drop-down lists and also avoid obscure acronyms (“NAF”) in it that are likely to cause more confusion than clarity.The URI identifiers given by LoC themselves start with “http://” but I have opted to use “https://” for the
urlso patrons etc. won’t need a redirect or similar to get to the page.Update: Also added an entry for autoselection of LoC when added the ID on the author editing page.
Testing
no97027235) and verify that the LoC entry gets selectedloc_nafidentifier gets shown on the Author pageStakeholders
@mekarpeles