Refactor subject pages to have re-usable macros #9786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9785
Extracts three subject page components into macros:
ProlificAuthors.html
: The list of prolific authors on a subjectPublishingHistory.html
: The publishing history graph for a subjectRelatedSubjects.html
: Links to related subject pagesAdditionally, removes unreferenced
renderPublishers
jsdef
function.The existing carousel is a
custom_carousel
template, and hasn't modified.Technical
renderSubjects
in theRelatedSubjects
macro is no longer ajsdef
function. This function worked properly when called from the browser console, but wasn't referenced in our codebase.The
renderAuthors
jsdef
function was not included in theProlificAuthors
macro. This function did not work properly when called from the console, due to anUncaught ReferenceError: page is not defined
error. Also, it isn't referenced in our codebase.Testing
Screenshot
Stakeholders