Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [alt] attributes to images #9761

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Add [alt] attributes to images #9761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0cee888
add alt attribute to imgs
Souvik-Cyclic Aug 17, 2024
56f98cd
Address review changes
Souvik-Cyclic Sep 5, 2024
bf6ed2d
Re-Add alt attribute to icon_link
Souvik-Cyclic Sep 5, 2024
018e86c
address review changes
Souvik-Cyclic Sep 5, 2024
2834dfc
address review changes
Souvik-Cyclic Sep 5, 2024
9741d29
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openlibrary/i18n/messages.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7308,6 +7308,10 @@ msgstr[1] ""
msgid "Related Books"
msgstr ""

#: EditionNavBar.html
msgid "Go to next section"
msgstr ""

#: Follow.html
msgid "UnfollowFollow"
msgstr ""
Expand Down
6 changes: 3 additions & 3 deletions openlibrary/macros/EditionNavBar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</li>
</ul>
$if not desktop_only:
<span class="nav-arrow">
<img src="/static/images/nav-arrow.svg" role="img">
</span>
<button class="nav-arrow" title="$_('Go to next section')">
<img src="/static/images/nav-arrow.svg" alt="">
</button>
</span>
2 changes: 1 addition & 1 deletion openlibrary/templates/account/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ <h1 class="details-title">$header_title</h1>
$set_share_links(url=request.canonical_url, title=header_title, view_context=ctx)
$if ctx.get('share_links'):
$ share_str = _('Share')
$ share_content = '<a class="cta-btn cta-btn--unstyled share-modal-link icon-link" href="javascript:;" data-ol-link-track="MyBooksModalLinkClick|ShareIcon"><img class="icon-link__image" src="/static/images/icons/share.svg" width="20"> %s</a>' % share_str
$ share_content = '<a class="cta-btn cta-btn--unstyled share-modal-link icon-link" href="javascript:;" data-ol-link-track="MyBooksModalLinkClick|ShareIcon"><img class="icon-link__image" src="/static/images/icons/share.svg" width="20" alt=""> %s</a>' % share_str
$ page_url = request.home
$ share_links = ctx.get('share_links')
$:macros.ShareModal(share_links, page_url, share_content, "share-modal-wrapper", show_embed=False)
Expand Down
2 changes: 1 addition & 1 deletion openlibrary/templates/type/edition/modal_links.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

$ ga_attr = 'data-ol-link-track=%s' % ga_data if ga_data else ''
<a href="$href" class="$link_class icon-link" $ga_attr>
<img class="icon-link__image" src="$img_src">
<img class="icon-link__image" src="$img_src" alt="">
<div class="icon-link__text">$link_text</div>
</a>

Expand Down
2 changes: 1 addition & 1 deletion openlibrary/templates/type/edition/title_and_author.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

$ ga_attr = 'data-ol-link-track=%s' % ga_data if ga_data else ''
<a href="$href" class="$link_class icon-link" $ga_attr>
<img class="icon-link__image" src="$img_src">
<img class="icon-link__image" src="$img_src" alt="">
<div class="icon-link__text">$link_text</div>
</a>

Expand Down
2 changes: 2 additions & 0 deletions static/css/components/nav-bar.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@

.nav-arrow {
padding-left: 20px;
background: none;
border: none;

img {
max-width: unset !important;
Expand Down
Loading