Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: minimum values for book dimensions and weight to prevent zero or negative inputs #9733

Conversation

Souvik-Cyclic
Copy link
Contributor

Closes #9731

Fix: Set minimum values for book dimensions and weight inputs to prevent zero or negative values

Technical

Sets minimum values for the book's weight and dimensions inputs to ensure that users cannot enter zero or negative values.

Weight: Minimum value adjusted to 0.01
Dimensions: Minimum value set to 0.1

Testing

  1. Verify Weight Input:
    Navigate to the book weight input field.
    Ensure the minimum allowed value is set to 0.01
    Try entering value below minimum and ensure they are not accepted.
    Check that the input fields correctly accept values at or above the minimum.

  2. Verify Dimensions Input:
    Navigate to the book dimensions inputs (height, width, depth).
    Ensure the minimum allowed value is set to 0.1
    Try entering value below minimum and ensure they are not accepted.
    Check that the input fields correctly accept values at or above the minimum.

Screenshot

image

Stakeholders

@mekarpeles

@mekarpeles
Copy link
Member

LGTM, thank you!

@mekarpeles mekarpeles merged commit 7aba1cd into internetarchive:master Aug 13, 2024
4 checks passed
@Souvik-Cyclic Souvik-Cyclic deleted the 9731/fix/book-dimensions-negative-or-zero branch August 13, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book dimensions negative or equal to zero
2 participants