Add "edition." prefix to search to only filter editions #9697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
9585/fix/add-edition-search-prefix
branch
from
2211f47 to
a7b7dc5
Compare
benbdeitch
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9585 . Adds a new optional prefix to search fields,
edition.to mirror ourwork.prefix. This allows you to apply a certain field only to the editions during search.Technical
Testing
Before: https://openlibrary.org/search?q=first_publish_year%3A%5B*+TO+1953%5D+language%3Aukr+-id_wikisource%3A*&mode=everything&sort=old&subject_facet=Nationalism
After: https://testing.openlibrary.org/search?q=first_publish_year%3A%5B*+TO+1953%5D+language%3Aukr+-edition.id_wikisource%3A*&mode=everything&sort=old&subject_facet=Nationalism
Screenshot
Stakeholders