Add endpoint to view status of batch import #9682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #9681 Add endpoint to view status of batch import (`/import/batch/<id>`). * **New Class and Endpoint:** - Add `BatchImportView` class in `openlibrary/plugins/openlibrary/code.py` for the path `/import/batch/(\d+)` with a `GET` handler. - Implement the `GET` handler to retrieve batch import status from the database. - Support pagination (`page` and `limit`) and sorting (`added_time`, `import_time`, `status`) in the handler. - Perform a `GROUP BY` query by `status` to get the total number of rows for the batch. * **Template for Batch Import View:** - Create a new template file `openlibrary/templates/batch_import_view.html` to display the batch import status. - Include a table with columns for all fields in the `import_item` table. - Support pagination and sorting in the table. - Display the grouped status counts at the top. * **Update Batch Import Template:** - Update `openlibrary/templates/batch_import.html` to link to the new endpoint after creating a batch. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/internetarchive/openlibrary/issues/9681?shareId=XXXX-XXXX-XXXX-XXXX).
for more information, see https://pre-commit.ci
cdrini
commented
Aug 2, 2024
cdrini
commented
Aug 2, 2024
scottbarnes
reviewed
Aug 9, 2024
| $for row in rows: | ||
| <tr> | ||
| <td>$datestr(row.added_time)</td> | ||
| <td>$datestr(row.import_time)</td> |
There was a problem hiding this comment.
Suggested change
| <td>$datestr(row.import_time)</td> | |
| $if row.import_time: | |
| <td>$datestr(row.import_time)</td> | |
| $else: | |
| <td>not yet imported</td> |
There was a problem hiding this comment.
I am not actually sure whether Templetor supports ternary operations, but something like this should avoid an error from datestr() when there is no row.import_time, which will be the case for pending and staged items.
scottbarnes
added
the
Needs: Submitter Input
cdrini
commented
Aug 9, 2024
github-actions
bot
removed
the
Needs: Submitter Input
for more information, see https://pre-commit.ci
Souvik-Cyclic
pushed a commit
to Souvik-Cyclic/openlibrary
that referenced
this pull request
Aug 17, 2024
SivanC
pushed a commit
to SivanC/openlibrary
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9681
Add endpoint to view status of batch import (
/import/batch/<id>).New Class and Endpoint:
BatchImportViewclass inopenlibrary/plugins/openlibrary/code.pyfor the path/import/batch/(\d+)with aGEThandler.GEThandler to retrieve batch import status from the database.pageandlimit) and sorting (added_time,import_time,status) in the handler.GROUP BYquery bystatusto get the total number of rows for the batch.Template for Batch Import View:
openlibrary/templates/batch_import_view.htmlto display the batch import status.import_itemtable.Update Batch Import Template:
openlibrary/templates/batch_import.htmlto link to the new endpoint after creating a batch.For more details, open the Copilot Workspace session.