Hide download options when book is unavailable. #9647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbarnes
reviewed
Jul 29, 2024
Co-authored-by: Scott Barnes <scottreidbarnes@gmail.com>
|
Hey @scottbarnes I tried finding some other fix, but I'm getting nowhere, have you got some leads or suggestion? |
|
@shubhiscoding, this looks good so far. I will try to review and possibly merge it tomorrow, but I have not set aside time to figure out all the test conditions we need. Currently I can't think of anything better, and if you can't also, then this may be the best way to do it. :) |
Extra space was breaking the template.
Use () to properly group the `or` conditions.
scottbarnes
approved these changes
Aug 2, 2024
Souvik-Cyclic
pushed a commit
to Souvik-Cyclic/openlibrary
that referenced
this pull request
Aug 17, 2024
* Hide download options when book is unavailable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9637
Added extra check before rendering download option to avoid it's visibility when the book is not present in Internet Archive
Technical
add same condition that was used to check if read button should be called in LoanStatus.html
(availability.get('is_readable') or availability.get('status') == 'open')Assuming that If a book is no longer available on Internet Archive then it would be Not be readable anyways.
Testing
Create a Book, search for the book by it's name and open it, by default it shows Not In Library, and you'll see that Download Options are not visible, while If you open any of the other Book which are available you'll be able to see Download options.
Screenshot
Available Book
Unavailable Book
Stakeholders
@scottbarnes